From owner-svn-src-head@freebsd.org Thu Jan 30 21:09:51 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id AA7461FF1A9 for ; Thu, 30 Jan 2020 21:09:51 +0000 (UTC) (envelope-from jroberson@jroberson.net) Received: from mail-pf1-x443.google.com (mail-pf1-x443.google.com [IPv6:2607:f8b0:4864:20::443]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 487tKB5lQnz4g1w for ; Thu, 30 Jan 2020 21:09:50 +0000 (UTC) (envelope-from jroberson@jroberson.net) Received: by mail-pf1-x443.google.com with SMTP id 2so2106141pfg.12 for ; Thu, 30 Jan 2020 13:09:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jroberson-net.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=2eJE1u5aSy2CaM4+lwy2L/ECnB3wcS58D5RhiPrA5tc=; b=f0BUWt0iolnS5ObLadlO15KkdJjN+QxvPoNysUeoKTZEP1TSywDOtRQK22ReOuzyN1 sSfol7kxa3Yk0xaKbXnDTHdYB9l19AP26nD+nMjsniEzZJ3r2GH4lZSLuVCMy84n4g9E 5gOzUc3qsaoOJPNmQ/MMj6Vys+LnUCLiCyqbtW7MA/im5ICxM0xhMGCWnwpKwYvVYbFt p8Xg3oj6YN0LrVNGNnmAsXCYO62TLGkC+U+X14YY2/a9z0XKZoi1egvU+RpJihI+ZT0Q 312aRmjmRAxnEf804XZv4RodOC9hPQHHw0bou4DTuK14QYMZO8j7j2/Xgn2r86SljZxO HdPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=2eJE1u5aSy2CaM4+lwy2L/ECnB3wcS58D5RhiPrA5tc=; b=j7IdwGmrNGVBjlo1Es2QWXNgdOiivi6B/1OB1stbcTSKU/RTfaEQO4MnxLMFPnPv01 k9E3vORuPWh5T4rW4QpAhq/knCslZrK9KU8HYD8L4hEQiHr11mU6F1AwOEU91BXvWh8e I3dT8z38aZthUN2gh8m8cuFbGI+4/crJAPgTwzOv5KDhkuRTyy3rxYG0BJc7bLWzn1rf oxEKF3lYnScgJP9mfSpkqLCBBekPJmy6IPeLGiQuGGgaDnj3jtxvd4lRp0jtBSZhVrmo Zk3pZbf+UDcrF5StZF2V8FR2leouxfKMRSEMD2cz6/PQR6z2A4oktusWRKdstHixqwR9 SWfQ== X-Gm-Message-State: APjAAAW9cwxR2Ac2g92RxDJhaQtbcqnfFdHU/HsoXLN0l5DCDr2ARN3D EiC+NQ/BkhjI/IsBOKH14RWMXQ== X-Google-Smtp-Source: APXvYqysVTyKOSJ9la5HUzvOdoCC8u45b5/48tY2qUG9kYGr5IXLa8nvzN0t4bJpgTVi+9OE4Gj9iQ== X-Received: by 2002:a63:cb47:: with SMTP id m7mr6639701pgi.309.1580418589813; Thu, 30 Jan 2020 13:09:49 -0800 (PST) Received: from rrcs-76-81-105-82.west.biz.rr.com (rrcs-76-81-105-82.west.biz.rr.com. [76.81.105.82]) by smtp.gmail.com with ESMTPSA id g7sm7813603pfq.33.2020.01.30.13.09.48 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 30 Jan 2020 13:09:49 -0800 (PST) Date: Thu, 30 Jan 2020 11:09:42 -1000 (HST) From: Jeff Roberson X-X-Sender: jroberson@desktop To: Gleb Smirnoff cc: Hans Petter Selasky , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r357293 - head/sys/net In-Reply-To: <20200130205629.GK1268@FreeBSD.org> Message-ID: References: <202001301204.00UC43Rw022059@repo.freebsd.org> <20200130205629.GK1268@FreeBSD.org> User-Agent: Alpine 2.21.9999 (BSF 287 2018-06-16) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed X-Rspamd-Queue-Id: 487tKB5lQnz4g1w X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=jroberson-net.20150623.gappssmtp.com header.s=20150623 header.b=f0BUWt0i; dmarc=none; spf=none (mx1.freebsd.org: domain of jroberson@jroberson.net has no SPF policy when checking 2607:f8b0:4864:20::443) smtp.mailfrom=jroberson@jroberson.net X-Spamd-Result: default: False [-2.71 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_DKIM_ALLOW(-0.20)[jroberson-net.20150623.gappssmtp.com:s=20150623]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[svn-src-head@freebsd.org]; DMARC_NA(0.00)[jroberson.net]; RCPT_COUNT_FIVE(0.00)[5]; RCVD_COUNT_THREE(0.00)[3]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[jroberson-net.20150623.gappssmtp.com:+]; RCVD_IN_DNSWL_NONE(0.00)[3.4.4.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; R_SPF_NA(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; MID_RHS_NOT_FQDN(0.50)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; RCVD_TLS_ALL(0.00)[]; IP_SCORE(-0.91)[ip: (-0.67), ipnet: 2607:f8b0::/32(-2.03), asn: 15169(-1.78), country: US(-0.05)] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Jan 2020 21:09:51 -0000 On Thu, 30 Jan 2020, Gleb Smirnoff wrote: > On Thu, Jan 30, 2020 at 12:04:03PM +0000, Hans Petter Selasky wrote: > H> Author: hselasky > H> Date: Thu Jan 30 12:04:02 2020 > H> New Revision: 357293 > H> URL: https://svnweb.freebsd.org/changeset/base/357293 > H> > H> Log: > H> Widen EPOCH(9) usage in netisr. > H> > H> Software interrupt handlers are allowed to sleep. In swi_net() there > H> is a read lock behind NETISR_RLOCK() which in turn ends up calling > H> msleep() which means the whole of swi_net() cannot be protected by an > H> EPOCH(9) section. By default the NETISR_LOCKING feature is disabled. > H> > H> This issue was introduced by r357004. This is a preparation step for > H> replacing the functionality provided by r357004. > H> > H> Found by: kib@ > H> Sponsored by: Mellanox Technologies > > What?! NETISR_RLOCK() which in turn ends up calling msleep()? Can you please > explain this nonsense? It does not look like NETISR_RLOCK is configured as sleepable so it just uses a mtx. Jeff > > -- > Gleb Smirnoff >