From owner-svn-src-all@FreeBSD.ORG Tue Dec 31 03:29:20 2013 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 6EDD6376; Tue, 31 Dec 2013 03:29:20 +0000 (UTC) Received: from mail-ie0-x235.google.com (mail-ie0-x235.google.com [IPv6:2607:f8b0:4001:c03::235]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 0FBA61A8C; Tue, 31 Dec 2013 03:29:20 +0000 (UTC) Received: by mail-ie0-f181.google.com with SMTP id e14so12720734iej.40 for ; Mon, 30 Dec 2013 19:29:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=1UEiP1L5DMizIrqAu4Id5eqdjUK6XT3tijXdRe5BJ1c=; b=bYODebS+VFFyEq5FLC6ZtJBoCX1DvITeR5ZAh/bROfJh1DE0pYsVDeoGXTDizb/tQe MANMWWIph9ghpZPVni+K5wGx0SHaL2w/glP+QcjxNV101+SXAL7FdWHpPDcpD1EE4BKG Yi5FNOg401lAk+WU4kqvo/RChFST+aUiWOBtvgY1VSvlyR+jzMllMWiz0BmPKC3RqXfy 28ProcmGxt5YPPAowKWn9INOEeeJ8HFsXGrUtdQZKlAqy0Sad22N8kdNcBD9DEmddWYv O4g+3PC7uw/EmpNLhcH+HiHMYtEamvz7Nxt4lVhI+wjiolTMWvnIu9FLUICCp19yfe8R dBAg== X-Received: by 10.50.29.114 with SMTP id j18mr57943142igh.24.1388460559385; Mon, 30 Dec 2013 19:29:19 -0800 (PST) Received: from charmander.home ([65.95.94.123]) by mx.google.com with ESMTPSA id o1sm62710885igh.9.2013.12.30.19.29.17 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 30 Dec 2013 19:29:18 -0800 (PST) Sender: Mark Johnston Date: Mon, 30 Dec 2013 22:28:46 -0500 From: Mark Johnston To: Pedro Giffuni Subject: Re: svn commit: r260091 - in head/sys/cddl: contrib/opensolaris/uts/common/dtrace contrib/opensolaris/uts/common/sys dev/dtrace Message-ID: <20131231032845.GB11997@charmander.home> References: <201312301737.rBUHbW3I035088@svn.freebsd.org> <20131230204210.GD71033@FreeBSD.org> <20131231023952.GA11997@charmander.home> <7A335B4A-D986-4E6E-8D8B-22E7E7991A75@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7A335B4A-D986-4E6E-8D8B-22E7E7991A75@FreeBSD.org> User-Agent: Mutt/1.5.22 (2013-10-16) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, Gleb Smirnoff , Mike Ma , src-committers@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 31 Dec 2013 03:29:20 -0000 On Mon, Dec 30, 2013 at 10:21:58PM -0500, Pedro Giffuni wrote: > > Il giorno 30/dic/2013, alle ore 21:40, Mark Johnston ha scritto: > > > On Tue, Dec 31, 2013 at 12:42:10AM +0400, Gleb Smirnoff wrote: > >> On Mon, Dec 30, 2013 at 05:37:32PM +0000, Mark Johnston wrote: > >> M> Author: markj > >> M> Date: Mon Dec 30 17:37:32 2013 > >> M> New Revision: 260091 > >> M> URL: http://svnweb.freebsd.org/changeset/base/260091 > >> M> > >> M> Log: > >> M> Now that vmem(9) is available, use vmem arenas to allocate probe and > >> M> aggregation IDs, as is done in the upstream illumos code. This still > >> M> requires some FreeBSD-specific code, as our vmem API is not identical to the > >> M> one in illumos. > >> M> > >> M> Submitted by: Mike Ma > >> > >> IMHO, alloc_unr() was lighter and thus better for allocating just IDs. > > > > That's true; I committed the change since it helps keep our code similar > > to upstream and, as Pedro notes, it was a long-standing todo item on the > > wiki. After doing some testing, it looks like vmem is a bit slower: > > process startup is on the order of tenths of milliseconds longer with > > this change, for executables containing one USDT probe (since such > > probes are allocated during process startup). > > > > So probably the right thing to do is revert this change. It doesn't > > actually reduce the upstream diff as much as I'd hoped, anyway. > > > > Since it is our option to decide, perhaps just keep the vmem version as reference and #ifdef FreeBSD alloc_unr() ? You mean just having #if defined(sun) vmem code #else *_unr code #endif ? That's what we'd get by reverting the change.