Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 11 Mar 2017 15:21:35 +0000 (UTC)
From:      Andriy Gapon <avg@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-10@freebsd.org
Subject:   svn commit: r315069 - stable/10/sys/modules/qlxgbe
Message-ID:  <201703111521.v2BFLZvM010039@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: avg
Date: Sat Mar 11 15:21:34 2017
New Revision: 315069
URL: https://svnweb.freebsd.org/changeset/base/315069

Log:
  qlxgbe: add GCC_MS_EXTENSIONS to CFLAGS to make old base GCC happy
  
  The module uses unnamed structure and union fields and base GCC in
  stable/10 doesn't like it.
  I think that that is a C11 feature, so it is courteous of more modern
  compilers to not complain about it when compiling in C99 mode.
  
  This is a direct commit as the change is not required in head.
  
  Approved by:	davidcs

Modified:
  stable/10/sys/modules/qlxgbe/Makefile

Modified: stable/10/sys/modules/qlxgbe/Makefile
==============================================================================
--- stable/10/sys/modules/qlxgbe/Makefile	Sat Mar 11 15:16:55 2017	(r315068)
+++ stable/10/sys/modules/qlxgbe/Makefile	Sat Mar 11 15:21:34 2017	(r315069)
@@ -43,6 +43,9 @@ SRCS+= ql_minidump.c
 
 SRCS+= device_if.h bus_if.h pci_if.h
 
+# Uses unnamed structure and union fields
+CFLAGS+= ${GCC_MS_EXTENSIONS}
+
 #CFLAGS += -DQL_DBG
 # Please turn off QL_LDFLASH_FW when you enable QL_ENABLE_ISCSI_TLV
 # You may comment out both QL_LDFLASH_FW and QL_ENABLE_ISCSI_TLV if you like



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201703111521.v2BFLZvM010039>