Date: Wed, 5 Mar 2003 09:50:15 -0800 (PST) From: "Simon 'portlint' Schubert" <corecode@corecode.ath.cx> To: freebsd-ports-bugs@FreeBSD.org Subject: Re: ports/48947: New port: BitTorrent, program for distributing/downloading .torrent files Message-ID: <200303051750.h25HoFDQ010064@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR ports/48947; it has been noted by GNATS.
From: "Simon 'portlint' Schubert" <corecode@corecode.ath.cx>
To: Andre Luiz dos Santos <andre@netvision.com.br>
Cc: FreeBSD-gnats-submit@FreeBSD.org
Subject: Re: ports/48947: New port: BitTorrent, program for
distributing/downloading .torrent files
Date: Wed, 5 Mar 2003 18:45:26 +0100
--FHY1_=.F518Wig4a
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Lately Andre Luiz dos Santos told:
> sed 's/^X//' >bittorrent/Makefile << 'END-of-bittorrent/Makefile'
[...]
> XPORTNAME= BitTorrent
port names should not start with a capital letter, no? (except when they
are really important which bittorrent is really not (yet))
[...]
> XCOMMENT= BitTorrent is a tool for distributing files
you don't need to include the portname in ${COMMENT}, eg:
COMMENT= Tool for distributing files
[...]
> X.for f in ${PYFILES}
> X ${INSTALL_SCRIPT} ${WRKSRC}/$f ${PREFIX}/bin/
> X ${LN} -fs $f ${PREFIX}/bin/${f:S/.py//}
> X.endfor
why is this? Are really *both* extensions neede (null and .py)?
> X.if !defined(NOPORTDOCS)
> X ${MKDIR} ${DOCSDIR}
> X.for f in ${DOCFILES}
> X ${INSTALL_MAN} ${WRKSRC}/$f ${DOCSDIR}
you want ${INSTALL_DATA}
> X.endfor
> X.endif
> X
> Xpost-install:
> X @${SED} -e "s:%%DOCSDIR%%:${DOCSDIR}:g" pkg-message >${PKGMESSAGE}
> X.if !defined(BATCH)
> X @${ECHO}
> X @${CAT} ${PKGMESSAGE}
> X @${ECHO}
> X.endif
you don't want this, really. just produces an ugly pkg-message when
being built on bento. just
@${SED} -e "s:%%DOCSDIR%%:${DOCSDIR}:g" ${PKGMESSAGE}
and delete this PKGMESSAGE definition above
> X%%PORTDOCS%%share/doc/BitTorrent/FAQ.txt
> X%%PORTDOCS%%share/doc/BitTorrent/README.txt
> X%%PORTDOCS%%share/doc/BitTorrent/credits.txt
> X%%PORTDOCS%%share/doc/BitTorrent/todo.txt
> X%%PORTDOCS%%share/doc/BitTorrent/INSTALL.unix.txt
> X%%PORTDOCS%%share/doc/BitTorrent/LICENSE.txt
> X%%PORTDOCS%%@dirrm share/doc/BitTorrent
when installing to ${DOCSDIR} you should replace share/doc/BitTorrent
with ${DOCSDIR} here too.
> sed 's/^X//' >bittorrent/pkg-message << 'END-of-bittorrent/pkg-message'
> XThe documentation is available at %%DOCSDIR%%.
this is not needed IMO. it's common knowledge that port's docs are (or
at least should be) in share/doc/${PORTNAME}
> X
> XIf you want to use the GUI, you'll have to install py-wxPython,
> Xthe following commands should do it:
> X
> X# cd /usr/ports/x11-toolkits/py-wxPython
> X# make install
perhaps you may want a WITH_GUI option and if set pull wxPython in?
--
/"\ http://corecode.ath.cx/#donate
\ /
\ ASCII Ribbon Campaign
/ \ Against HTML Mail and News
--FHY1_=.F518Wig4a
Content-Type: application/pgp-signature
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (FreeBSD)
iD8DBQE+Zje5r5S+dk6z85oRAqfsAKC6+99p1Da+LG1As2fc1Z2Y+UYl4gCeI03Y
YTBw/loj1goXv24tfIWzPaY=
=nkLh
-----END PGP SIGNATURE-----
--FHY1_=.F518Wig4a--
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports-bugs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200303051750.h25HoFDQ010064>