Date: Tue, 6 May 2003 05:10:15 -0700 (PDT) From: Sergei Kolobov <sergei@kolobov.com> To: freebsd-ports-bugs@FreeBSD.org Subject: Re: ports/49961: [PATCH] Mega tree sweep for SITE_PERL usage Message-ID: <200305061210.h46CAF17014068@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR ports/49961; it has been noted by GNATS.
From: Sergei Kolobov <sergei@kolobov.com>
To: FreeBSD-gnats-submit@FreeBSD.org, ports@FreeBSD.org
Cc:
Subject: Re: ports/49961: [PATCH] Mega tree sweep for SITE_PERL usage
Date: Tue, 6 May 2003 16:04:47 +0400
On 2003-03-12 at 14:34 -0000, Sergei Kolobov wrote:
> This is a sweep through the ports tree looking for possible usage of SITE_PERL
> in Makefile and pkg-plist:
>
> -RUN_DEPENDS= ${LOCALBASE}/lib/perl5/site_perl/${PERL_VER}/${PERL_ARCH}/Tk.pm:${PORTSDIR}/x11-toolkits/p5-T
> k
> +RUN_DEPENDS= ${SITE_PERL}/${PERL_ARCH}/Tk.pm:${PORTSDIR}/x11-toolkits/p5-Tk
>
> and
>
> -lib/perl5/site_perl/%%PERL_VER%%/X11/Protocol/Connection/UNIXSocket.pm
> +%%SITE_PERL%%/X11/Protocol/Connection/UNIXSocket.pm
>
> IMHO, Makefiles and pkg-plists are much more readable and maintainable this way.
>
> Note: there are some edge cases - when a variable was defined for the same purpose
> as SITE_PERL, but with a different name (e.g. PERL_SITELIBDIR, etc.).
> My script did not handle those case yet.
> >How-To-Repeat:
> >Fix:
> The patches are available at the following URL:
>
> http://www.kolobov.com/site_perl.patches.tar.gz
>
> The tarball contains a collection of patch files, each file corresponds to a separate ports category.
I have created the patched almost 2 months ago and they are getting
stale already.
Can I ask a committer with some interest in Perl to take a look at them, please?
Thanks.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200305061210.h46CAF17014068>