From nobody Wed Aug 30 20:27:05 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4RbbbB2vxMz4sSL6 for ; Wed, 30 Aug 2023 20:33:10 +0000 (UTC) (envelope-from kevin.bowling@kev009.com) Received: from mail-ot1-x32b.google.com (mail-ot1-x32b.google.com [IPv6:2607:f8b0:4864:20::32b]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4RbbbB0tW9z4QZG for ; Wed, 30 Aug 2023 20:33:10 +0000 (UTC) (envelope-from kevin.bowling@kev009.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-ot1-x32b.google.com with SMTP id 46e09a7af769-6befdb1f545so167022a34.3 for ; Wed, 30 Aug 2023 13:33:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kev009.com; s=google; t=1693427588; x=1694032388; darn=freebsd.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=f3flemR6dvGwzgvc8EdaBS/r9dc7GhjIeCQiIuKVfnA=; b=Y67Ggsfg3Nha3pkH8xOFKm7udFmWdpgpKXxqRobAv3StCoxdEmkPxj9ko4YnGUVEKA EhDEliS0bz/szYETv3YztS+lk7PAiDApsC1cBOaazrWptkFFMULtyVkUOyZOXoVfHFvE Jw0JZaxXqkM2uxYvSNhcf7CJ1osymz3+tGB90= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693427588; x=1694032388; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=f3flemR6dvGwzgvc8EdaBS/r9dc7GhjIeCQiIuKVfnA=; b=WjKdIDIi9K3XkH/4tokds0T9cjJohm6eyoIiaHIKGwAAfJMi8Z9/olhH1SJbmpCEko 7Dgu8WjzFek4Hd5HOVDZRZwHuiRhVAXbj6MAXA/BM+aQXsTiaYldsGE76cUEHJIx/j1T GfnnqGwmb+FGA0wBzQbtGAQln10nPgFF4dLhbIPLY+ilhw6e42RwVrsAOEFM50F0vswO 2NEJbDky35IvPuIiN1YKRX5lWhtL5sbAQdi/P64VC/2j82M4GvtCqWhSkKTiMhT0d3Gq j0Cmq5mjhYbNS68wqCLSlFDcVzaESeo35TRh7POW3MYB8S0lBzhG9/S2nUQi5grUAysV otwQ== X-Gm-Message-State: AOJu0YwUORq5JFooEioFqlg9Qj8LWku6TKi/3J4AVd0fFvS+w91O+F72 N+8U9xbRzxIpLQei7MCYhQdN40XrLLxu+iOEgBNGKMnaHxeYG9Mo X-Google-Smtp-Source: AGHT+IGBKG7BU0EdWfJyq+TY4YAjjYRwGh+s7rWjUkvZMZrdxPpiq/LZgrJhdyR3MQhe/gzf3if9OdSWKlVHeKhmn4U= X-Received: by 2002:a05:6a21:7899:b0:12f:382d:2a37 with SMTP id bf25-20020a056a21789900b0012f382d2a37mr4359948pzc.15.1693427236715; Wed, 30 Aug 2023 13:27:16 -0700 (PDT) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 References: <202308242051.37OKpwUA039462@gitrepo.freebsd.org> <34CADCBB-B5E2-4E41-816E-4FAD36C474C3@FreeBSD.org> In-Reply-To: <34CADCBB-B5E2-4E41-816E-4FAD36C474C3@FreeBSD.org> From: Kevin Bowling Date: Wed, 30 Aug 2023 13:27:05 -0700 Message-ID: Subject: Re: git: b6b75424c57d - main - vmxnet3: Don't restart on VLAN changes To: Kristof Provost Cc: Kevin Bowling , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org, mmendoza@netgate.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US] X-Rspamd-Queue-Id: 4RbbbB0tW9z4QZG On Wed, Aug 30, 2023 at 12:53=E2=80=AFPM Kristof Provost w= rote: > > On 24 Aug 2023, at 22:51, Kevin Bowling wrote: > > The branch main has been updated by kbowling: > > URL: https://cgit.FreeBSD.org/src/commit/?id=3Db6b75424c57d6da49967fef39f= 69080ce6939207 > > commit b6b75424c57d6da49967fef39f69080ce6939207 > Author: Kevin Bowling > AuthorDate: 2023-08-24 20:25:21 +0000 > Commit: Kevin Bowling > CommitDate: 2023-08-24 20:46:56 +0000 > > vmxnet3: Don't restart on VLAN changes > > In rS360398, a new iflib device method was added with default of opt out > for VLAN events needing an interface reset. > > This re-init is unintentional for vmxnet3(4). > > > It looks like we do need to re-init vmx interfaces when vlans are set. Ma= rcos has an ESXi 7.0.3 setup that breaks with this patch series. > This fixes it: Ok, feel free to push. > > diff --git a/sys/dev/vmware/vmxnet3/if_vmx.c b/sys/dev/vmware/vmxnet3/if_= vmx.c > index 2c3530a217f..fdcad0dd4bb 100644 > --- a/sys/dev/vmware/vmxnet3/if_vmx.c > +++ b/sys/dev/vmware/vmxnet3/if_vmx.c > @@ -2513,6 +2513,7 @@ vmxnet3_if_needs_restart(if_ctx_t ctx __unused, enu= m iflib_restart_event event) > { > switch (event) { > case IFLIB_RESTART_VLAN_CONFIG: > + return (true); > default: > return (false); > } > > Best regards, > Kristof