Date: Wed, 30 Aug 2023 13:27:05 -0700 From: Kevin Bowling <kevin.bowling@kev009.com> To: Kristof Provost <kp@freebsd.org> Cc: Kevin Bowling <kbowling@freebsd.org>, src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org, mmendoza@netgate.com Subject: Re: git: b6b75424c57d - main - vmxnet3: Don't restart on VLAN changes Message-ID: <CAK7dMtAHpHqDycn2=tVAf99gcBDTTY-dXNp9v2_z4hxi6q_a4g@mail.gmail.com> In-Reply-To: <34CADCBB-B5E2-4E41-816E-4FAD36C474C3@FreeBSD.org> References: <202308242051.37OKpwUA039462@gitrepo.freebsd.org> <34CADCBB-B5E2-4E41-816E-4FAD36C474C3@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Aug 30, 2023 at 12:53=E2=80=AFPM Kristof Provost <kp@freebsd.org> w= rote: > > On 24 Aug 2023, at 22:51, Kevin Bowling wrote: > > The branch main has been updated by kbowling: > > URL: https://cgit.FreeBSD.org/src/commit/?id=3Db6b75424c57d6da49967fef39f= 69080ce6939207 > > commit b6b75424c57d6da49967fef39f69080ce6939207 > Author: Kevin Bowling <kbowling@FreeBSD.org> > AuthorDate: 2023-08-24 20:25:21 +0000 > Commit: Kevin Bowling <kbowling@FreeBSD.org> > CommitDate: 2023-08-24 20:46:56 +0000 > > vmxnet3: Don't restart on VLAN changes > > In rS360398, a new iflib device method was added with default of opt out > for VLAN events needing an interface reset. > > This re-init is unintentional for vmxnet3(4). > > > It looks like we do need to re-init vmx interfaces when vlans are set. Ma= rcos has an ESXi 7.0.3 setup that breaks with this patch series. > This fixes it: Ok, feel free to push. > > diff --git a/sys/dev/vmware/vmxnet3/if_vmx.c b/sys/dev/vmware/vmxnet3/if_= vmx.c > index 2c3530a217f..fdcad0dd4bb 100644 > --- a/sys/dev/vmware/vmxnet3/if_vmx.c > +++ b/sys/dev/vmware/vmxnet3/if_vmx.c > @@ -2513,6 +2513,7 @@ vmxnet3_if_needs_restart(if_ctx_t ctx __unused, enu= m iflib_restart_event event) > { > switch (event) { > case IFLIB_RESTART_VLAN_CONFIG: > + return (true); > default: > return (false); > } > > Best regards, > Kristof
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAK7dMtAHpHqDycn2=tVAf99gcBDTTY-dXNp9v2_z4hxi6q_a4g>