From owner-svn-src-head@freebsd.org Sun Sep 27 12:26:56 2015 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 32F96A0A92C; Sun, 27 Sep 2015 12:26:56 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from mx1.sbone.de (mx1.sbone.de [IPv6:2a01:4f8:130:3ffc::401:25]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client CN "mx1.sbone.de", Issuer "SBone.DE" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id E266EC65; Sun, 27 Sep 2015 12:26:55 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from mail.sbone.de (mail.sbone.de [IPv6:fde9:577b:c1a9:31::2013:587]) (using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by mx1.sbone.de (Postfix) with ESMTPS id 5197F25D387C; Sun, 27 Sep 2015 12:26:53 +0000 (UTC) Received: from content-filter.sbone.de (content-filter.sbone.de [IPv6:fde9:577b:c1a9:31::2013:2742]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPS id 60783C770BD; Sun, 27 Sep 2015 12:26:52 +0000 (UTC) X-Virus-Scanned: amavisd-new at sbone.de Received: from mail.sbone.de ([IPv6:fde9:577b:c1a9:31::2013:587]) by content-filter.sbone.de (content-filter.sbone.de [fde9:577b:c1a9:31::2013:2742]) (amavisd-new, port 10024) with ESMTP id MjVqNRmBDXo3; Sun, 27 Sep 2015 12:26:50 +0000 (UTC) Received: from nv.sbone.de (nv.sbone.de [IPv6:fde9:577b:c1a9:31::2013:138]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPSA id 1CFE1C770B3; Sun, 27 Sep 2015 12:26:49 +0000 (UTC) Date: Sun, 27 Sep 2015 12:26:48 +0000 (UTC) From: "Bjoern A. Zeeb" To: "Alexander V. Chernikov" , George Neville-Neil cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r288301 - in head/sys: net netinet netinet6 In-Reply-To: <201509270529.t8R5TYRf095540@repo.freebsd.org> Message-ID: References: <201509270529.t8R5TYRf095540@repo.freebsd.org> X-OpenPGP-Key-Id: 0x14003F198FEFA3E77207EE8D2B58B8F83CCF1842 MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 27 Sep 2015 12:26:56 -0000 On Sun, 27 Sep 2015, Alexander V. Chernikov wrote: > Author: melifaro > Date: Sun Sep 27 05:29:34 2015 > New Revision: 288301 > URL: https://svnweb.freebsd.org/changeset/base/288301 > > Log: > Eliminate nd6_nud_hint() and its TCP bindings. > > Initially function was introduced in r53541 (KAME initial commit) to > "provide hints from upper layer protocols that indicate a connection > is making "forward progress"" (quote from RFC 2461 7.3.1 Reachability > Confirmation). > However, it was converted to do nothing (e.g. just return) in r122922 > (tcp_hostcache implementation) back in 2003. Some defines were moved > to tcp_var.h in r169541. Then, it was broken (for non-corner cases) > by r186119 (L2<>L3 split) in 2008 (NULL ifp in nd6_lookup). So, > right now this code is broken and has no "real" base users. > > Differential Revision: https://reviews.freebsd.org/D3699 PR: 165692 It would be nice to have the feature back though it would be very expensive locking wise if it'd remain a per-packet operation. -- Bjoern A. Zeeb "Come on. Learn, goddamn it.", WarGames, 1983