From owner-cvs-all  Thu Nov 30 15:14:59 2000
Delivered-To: cvs-all@freebsd.org
Received: from freefall.freebsd.org (freefall.FreeBSD.org [216.136.204.21])
	by hub.freebsd.org (Postfix) with ESMTP
	id 6189337B400; Thu, 30 Nov 2000 15:14:55 -0800 (PST)
Received: (from rwatson@localhost)
	by freefall.freebsd.org (8.11.1/8.11.1) id eAUNEtP18095;
	Thu, 30 Nov 2000 15:14:55 -0800 (PST)
	(envelope-from rwatson)
Message-Id: <200011302314.eAUNEtP18095@freefall.freebsd.org>
From: Robert Watson <rwatson@FreeBSD.org>
Date: Thu, 30 Nov 2000 15:14:55 -0800 (PST)
To: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: cvs commit: src/usr.bin/su su.c
X-FreeBSD-CVS-Branch: HEAD
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG

rwatson     2000/11/30 15:14:55 PST

  Modified files:
    usr.bin/su           su.c 
  Log:
  o Make comment match reality, synch code with comment.
  o In practice: the comment indicates that all but umask and
    environmental variables of the users login class are applied when su
    occurs, unless -m is used to specify a class.  This was incorrect;
    in practice, the uid, gids, resources, and priority were set, and
    then resources and priority were selectively removed.  This meant
    that some aspects of the user context were not set, including handling
    of login events (wtmp, utmp), as well as the path specified in
    login.conf.
  o I changed it so that the behavior is the same, but instead,
    LOGIN_SETALL is used, and appropriate flags are removed, including
    the LOGIN_SETLOGIN and LOGIN_SETPATH entries that were implicitly
    not present before.  I also updated the comment to reflect
    reality, selecting reality as the "correct" behavior.
  o This has the practical benefit that as new LOGIN_SET* flags are
    introduced, they are supported by su unless specifically disabled.
    For example, of a LOGIN_SETLABEL flag is introduced to support
    MAC labels determined by the user's login class, then su no longer
    has to be modified.
  o It might be desirable to have su use LOGIN_SETPATH depending on
    its command line parameters, as it might or might not be
    considered part of the "environment".
  
  Obtained from:	TrustedBSD Project
  
  Revision  Changes    Path
  1.35      +11 -3     src/usr.bin/su/su.c



To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message