From owner-freebsd-current@FreeBSD.ORG Fri Feb 3 23:51:26 2006 Return-Path: X-Original-To: freebsd-current@freebsd.org Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3A5E916A422 for ; Fri, 3 Feb 2006 23:51:26 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from cyrus.watson.org (cyrus.watson.org [209.31.154.42]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9F23E43D48 for ; Fri, 3 Feb 2006 23:51:25 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from fledge.watson.org (fledge.watson.org [209.31.154.41]) by cyrus.watson.org (Postfix) with ESMTP id 207AA46CAE; Fri, 3 Feb 2006 18:51:16 -0500 (EST) Date: Fri, 3 Feb 2006 23:53:34 +0000 (GMT) From: Robert Watson X-X-Sender: robert@fledge.watson.org To: Max Laier In-Reply-To: <200602040028.47826.max@love2party.net> Message-ID: <20060203235235.T1100@fledge.watson.org> References: <20060203230755.B8CA57302F@freebsd-current.sentex.ca> <200602040028.47826.max@love2party.net> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: freebsd-current@freebsd.org Subject: Re: [head tinderbox] failure on amd64/amd64 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Feb 2006 23:51:26 -0000 On Sat, 4 Feb 2006, Max Laier wrote: > On Saturday 04 February 2006 00:07, FreeBSD Tinderbox wrote: >> -finstrument-functions -Wno-inline /src/sys/security/audit/audit_arg.c >> /src/sys/security/audit/audit_arg.c: In function `audit_arg_upath': >> /src/sys/security/audit/audit_arg.c:676: warning: long long unsigned int >> format, u_int64_t arg (arg 2) /src/sys/security/audit/audit_arg.c:678: >> warning: long long unsigned int format, u_int64_t arg (arg 2) *** Error >> code 1 > > Once again, fixed by - for example - the attached patch. Alternatively: > .. "%ju", (uintmax_t)arg .. // we are so C99 > > I take this a chance to rant if we could remove this stupid 64bit > unportability. It should be possible to have a CASSERT somewhere that shuts > this up if "sizeof(u_int64_t) == sizeof(unsigned long long)" or the like. > I hope somebody has more insight and how/where to fix it properly. > Otherwise we will run into this portability issue over and over again. Thanks. I just realized I did my amd64 test builds without INVARIANTS compiled in. Patch committed. No opinion on the format string thing, except that I keep shooting the feet of myself and others. Robert N M Watson