From owner-svn-src-head@FreeBSD.ORG Mon Mar 30 22:21:06 2015 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 155CD33B for ; Mon, 30 Mar 2015 22:21:06 +0000 (UTC) Received: from mail-pa0-x235.google.com (mail-pa0-x235.google.com [IPv6:2607:f8b0:400e:c03::235]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id C61F3BB for ; Mon, 30 Mar 2015 22:21:05 +0000 (UTC) Received: by padcy3 with SMTP id cy3so179626757pad.3 for ; Mon, 30 Mar 2015 15:21:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netflix.com; s=google; h=content-type:mime-version:subject:from:in-reply-to:date:cc :message-id:references:to; bh=xbWn4onIjvHSF55JtmBGIH41b/x0tIUv0ekK5l2SevI=; b=Hsyd+9YjO6fWLyU/dAiAkea5MHrlaJA8XjahrjCh14cBKrf2gPOkmOK81+XSwY1xFF atcNRJ5UpOUZZoDI//3f3ytkvqS1JroERNv3oDSB34BwyxyE0maQJ1x/vPcYdNlWl8Rv nHp2mMzOV7PFu4e2uyhvCcUwB6vImfjUFtkm0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:content-type:mime-version:subject:from :in-reply-to:date:cc:message-id:references:to; bh=xbWn4onIjvHSF55JtmBGIH41b/x0tIUv0ekK5l2SevI=; b=TRTbPA+jEA3dIvGMOZmZh3je+yB+dWoWmoOVJHxEUSH7nOvRr4b0U5iFDyUpqVLESW HeVAGTSGQPDPwDWkVKYSoh7wpqVP7dwbVq6jhmuAXGNX+bbzLQy7Z8O7rh+KYQMpbvo+ fMCXIInYQwyQArO0W2337N9mdvZPIDFPAMM35DSCDogQi8EFk71AiqW2mLPfi2Nb/EVv Icl9XXpiCJJ2l0fhHcEBXoNTNevAUZmxRsl/ipd+4aUxNp9gNOtN7HL6snAoGf8VxBhj 1Jbe1K6m28Cp+WiqtdQPwWQgqcgmrWTxVwZsYeQbgwd9zjX39/SCAOaLmXBgWz0wkD5t Hp+w== X-Gm-Message-State: ALoCoQn/tGEOIN38kzg5cOdm3GiNax9Z9W6OCXTrrILocH808EU38Xeyd8ASW1E7rESYJGRTzKB0 X-Received: by 10.70.65.39 with SMTP id u7mr62609129pds.11.1427754065409; Mon, 30 Mar 2015 15:21:05 -0700 (PDT) Received: from ?IPv6:2607:fb10:2:236:6412:7db4:a40e:aec0? ([2607:fb10:2:236:6412:7db4:a40e:aec0]) by mx.google.com with ESMTPSA id jh2sm11717440pbb.25.2015.03.30.15.21.03 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 30 Mar 2015 15:21:04 -0700 (PDT) Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\)) Subject: Re: svn commit: r280785 - in head/sys: kern netgraph/atm/sscop netgraph/atm/uni sys From: Randall Stewart In-Reply-To: <3218826.nq4nR2EqCz@ralph.baldwin.cx> Date: Mon, 30 Mar 2015 16:21:03 -0600 Message-Id: References: <201503281250.t2SCoOkt020297@svn.freebsd.org> <4E7E0A0A-5125-4F3A-AC0C-D428A972C954@netflix.com> <3218826.nq4nR2EqCz@ralph.baldwin.cx> To: John Baldwin X-Mailer: Apple Mail (2.1878.6) Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.18-1 Cc: Davide Italiano , "svn-src-head@freebsd.org" , "svn-src-all@freebsd.org" , "src-committers@freebsd.org" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Mar 2015 22:21:06 -0000 John: As I just said, Warner and I feel we can get by with making the int -> = short/short so we preserver the KPI and at the same time achieve the objective .. My big concern was no intel platforms but Warner gave me a green light = there ;-) R On Mar 30, 2015, at 10:10 AM, John Baldwin wrote: > On Saturday, March 28, 2015 01:48:49 PM Davide Italiano wrote: >> On Sat, Mar 28, 2015 at 12:04 PM, Randall Stewart = wrote: >>> Hmm does the KPI include the size of the callout structure (which is >>> private)? >>>=20 >>=20 >> It's KBI, not KPI. >>=20 >>> If so I suppose we could change the c_flags/c_iflags to >>> ushort =85 >>>=20 >>=20 >> I'm not familiar with your changes enough to suggest/propose a fix. >> As I previously mentioned, this looks suspicious KBI-wise to me, and = I >> reported to you. >=20 > The KBI issue makes it much harder to MFC. In particular, even though > you could move 'c_iflags' to the end to fix most things (though not > callout_pending()), many drivers have 'struct callout foo' inside = their > softc, etc. and this would break existing modules. >=20 > OTOH, the uglier hack of adding locking in callout_deactivate() would > preserve the KBI and be safe to merge. >=20 > --=20 > John Baldwin -------- Randall Stewart rrs@netflix.com 803-317-4952