From owner-svn-src-head@freebsd.org Thu Dec 1 16:32:16 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1E979C60E48 for ; Thu, 1 Dec 2016 16:32:16 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from outbound1b.ore.mailhop.org (outbound1b.ore.mailhop.org [54.200.247.200]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id F0A081CD1 for ; Thu, 1 Dec 2016 16:32:15 +0000 (UTC) (envelope-from ian@freebsd.org) X-MHO-User: b6b4de07-b7e3-11e6-9f67-d3961ed5a660 X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information X-Originating-IP: 73.78.92.27 X-Mail-Handler: DuoCircle Outbound SMTP Received: from ilsoft.org (unknown [73.78.92.27]) by outbound1.ore.mailhop.org (Halon) with ESMTPSA id b6b4de07-b7e3-11e6-9f67-d3961ed5a660; Thu, 01 Dec 2016 16:32:13 +0000 (UTC) Received: from rev (rev [172.22.42.240]) by ilsoft.org (8.15.2/8.15.2) with ESMTP id uB1GW7IP003818; Thu, 1 Dec 2016 09:32:07 -0700 (MST) (envelope-from ian@freebsd.org) Message-ID: <1480609927.1889.189.camel@freebsd.org> Subject: Re: svn commit: r309344 - head/lib/libutil From: Ian Lepore To: Ngie Cooper , "Conrad E. Meyer" Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Date: Thu, 01 Dec 2016 09:32:07 -0700 In-Reply-To: <4DFE017D-90FD-44F4-8FE7-7EE53D499F7B@gmail.com> References: <201612010221.uB12Lb6x067202@repo.freebsd.org> <4DFE017D-90FD-44F4-8FE7-7EE53D499F7B@gmail.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.5.1 FreeBSD GNOME Team Port Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Dec 2016 16:32:16 -0000 On Wed, 2016-11-30 at 19:07 -0800, Ngie Cooper wrote: > > > > On Nov 30, 2016, at 18:21, Conrad E. Meyer wrote: > > > > Author: cem > > Date: Thu Dec  1 02:21:36 2016 > > New Revision: 309344 > > URL: https://svnweb.freebsd.org/changeset/base/309344 > > > > Log: > >  Remove a death threat from the FreeBSD sources > > > >  Reported by:    koobs@, araujo@, linimon@, bjk@, emaste@, jhb@, > > ngie@, cem@ > >  Maintainer timeout:    des@ > Really?? I wish you hadn't added me to this list.. I don't in any way > endorse the way that you went about dealing with this disagreement. > You kind of just pissed all over what des@ did out of spite. > > Really?  Well then feel free to ADD my name to the list of people who found that comment, and the subsequent non-response to the complaints about it, completely inappropriate.   -- Ian > > > > > > Modified: > >  head/lib/libutil/flopen.c > > > > Modified: head/lib/libutil/flopen.c > > =================================================================== > > =========== > > --- head/lib/libutil/flopen.c    Thu Dec  1 01:56:34 > > 2016    (r309343) > > +++ head/lib/libutil/flopen.c    Thu Dec  1 02:21:36 > > 2016    (r309344) > > @@ -40,10 +40,10 @@ __FBSDID("$FreeBSD$"); > > /* > >  * Reliably open and lock a file. > >  * > > - * DO NOT, UNDER PAIN OF DEATH, modify this code without first > > reading the > > - * revision history and discussing your changes with > org>. > > - * Don't be fooled by the code's apparent simplicity; there would > > be no > > - * need for this function if it was as easy to get right as you > > think. > > + * Please do not modify this code without first reading the > > revision history > > + * and discussing your changes with .  Don't be > > fooled by the > > + * code's apparent simplicity; there would be no need for this > > function if it > > + * was easy to get right. > >  */ > > int > > flopen(const char *path, int flags, ...) > > @@ -108,7 +108,11 @@ flopen(const char *path, int flags, ...) > >            errno = serrno; > >            return (-1); > >        } > > -#ifdef DONT_EVEN_THINK_ABOUT_IT > > +        /* > > +         * The following change is provided as a specific example > > to > > +         * avoid. > > +         */ > > +#if 0 > >        if (fcntl(fd, F_SETFD, FD_CLOEXEC) != 0) { > >            serrno = errno; > >            (void)close(fd); > > >