From owner-cvs-src@FreeBSD.ORG  Fri Apr 25 08:50:32 2003
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 1538337B401; Fri, 25 Apr 2003 08:50:32 -0700 (PDT)
Received: from ebb.errno.com (ebb.errno.com [66.127.85.87])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 59ED843FBF; Fri, 25 Apr 2003 08:50:31 -0700 (PDT)
	(envelope-from sam@errno.com)
Received: from melange (melange.errno.com [66.127.85.82])
	(authenticated bits=0)
	by ebb.errno.com (8.12.9/8.12.9) with ESMTP id h3PFoUpw047269
	(version=TLSv1/SSLv3 cipher=RC4-MD5 bits=128 verify=NO);
	Fri, 25 Apr 2003 08:50:31 -0700 (PDT)
	(envelope-from sam@errno.com)
Message-ID: <06fe01c30b42$66705210$52557f42@errno.com>
From: "Sam Leffler" <sam@errno.com>
To: "Nate Lawson" <nate@root.org>, <cvs-all@FreeBSD.org>,
	<cvs-src@FreeBSD.org>, <src-committers@FreeBSD.org>
References: <Pine.BSF.4.21.0304250204280.64445-100000@root.org>
Date: Fri, 25 Apr 2003 08:50:30 -0700
Organization: Errno Consulting
MIME-Version: 1.0
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
X-Priority: 3
X-MSMail-Priority: Normal
X-Mailer: Microsoft Outlook Express 5.50.4920.2300
X-MimeOLE: Produced By Microsoft MimeOLE V5.50.4920.2300
Subject: Re: cvs commit: src/sys/dev/fxp if_fxp.c if_fxpvar.h
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 25 Apr 2003 15:50:32 -0000

> For developers, note that the locking in the code path only protects the
> various fxp routines (fxp_start, fxp_intr, fxp_tick, ...) and is not
> intended to serialize access to ANY external structures.  This is how it
> should be.  Please do not copy the exact approach taken here for a little
> while until ifnet locking is finished as there may need to be some changes
> made to this model.

This doesn't make much sense to me.  I've locked numerous chunks of code and
used a totally different approach: synchronize access to data structures,
not code paths.  Perhaps you and Jeffrey Hsu need to have a private
discussion...

    Sam