From owner-svn-src-head@freebsd.org Wed Jan 31 16:14:09 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id ECD4AED43CB; Wed, 31 Jan 2018 16:14:08 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from mail.baldwin.cx (bigwig.baldwin.cx [IPv6:2001:470:1f11:75::1]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 8F3286BA29; Wed, 31 Jan 2018 16:14:08 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from ralph.baldwin.cx (ralph.baldwin.cx [66.234.199.215]) by mail.baldwin.cx (Postfix) with ESMTPSA id A432310A8BA; Wed, 31 Jan 2018 11:14:07 -0500 (EST) From: John Baldwin To: Ed Maste Cc: Wojciech Macek , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r328610 - head/sys/amd64/amd64 Date: Wed, 31 Jan 2018 08:14:03 -0800 Message-ID: <3114578.qyyx4qh6ii@ralph.baldwin.cx> User-Agent: KMail/4.14.10 (FreeBSD/11.1-STABLE; KDE/4.14.30; amd64; ; ) In-Reply-To: References: <201801302329.w0UNTRHn080138@repo.freebsd.org> <3195814.6PcFLP86qD@ralph.baldwin.cx> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.4.3 (mail.baldwin.cx); Wed, 31 Jan 2018 11:14:07 -0500 (EST) X-Virus-Scanned: clamav-milter 0.99.2 at mail.baldwin.cx X-Virus-Status: Clean X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 31 Jan 2018 16:14:09 -0000 On Wednesday, January 31, 2018 10:31:36 AM Ed Maste wrote: > On 30 January 2018 at 21:01, John Baldwin wrote: > > On Tuesday, January 30, 2018 11:29:27 PM John Baldwin wrote: > >> Author: jhb > >> Date: Tue Jan 30 23:29:27 2018 > >> New Revision: 328610 > >> URL: https://svnweb.freebsd.org/changeset/base/328610 > >> > >> Log: > >> Ensure 'name' is not NULL before passing to strcmp(). > >> > >> This avoids a nested page fault when obtaining a stack trace in DDB if > >> the address from the first frame does not resolve to a known symbol. > >> > >> MFC after: 1 week > >> Sponsored by: Chelsio Communications > > > > This appears to be fallout from lld? After fixing this, the stack trace > > for my next panic shows no symbols for functions in the kernel, only > > functions in kernel modules: > > It's fallout from loader changes in r328536. I reverted r328536 (and > r328603) locally and stack traces are fixed. Ouch. I'll try to look at this later today unless someone else beats me to it. -- John Baldwin