From owner-svn-ports-head@FreeBSD.ORG Thu Jan 3 23:42:40 2013 Return-Path: Delivered-To: svn-ports-head@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id E8F51384; Thu, 3 Jan 2013 23:42:40 +0000 (UTC) (envelope-from hrs@FreeBSD.org) Received: from mail.allbsd.org (gatekeeper.allbsd.org [IPv6:2001:2f0:104:e001::32]) by mx1.freebsd.org (Postfix) with ESMTP id C9BD2E3A; Thu, 3 Jan 2013 23:42:39 +0000 (UTC) Received: from alph.allbsd.org (p1137-ipbf1505funabasi.chiba.ocn.ne.jp [118.7.212.137]) (authenticated bits=128) by mail.allbsd.org (8.14.5/8.14.5) with ESMTP id r03NgLCa067011 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 4 Jan 2013 08:42:32 +0900 (JST) (envelope-from hrs@FreeBSD.org) Received: from localhost (localhost [127.0.0.1]) (authenticated bits=0) by alph.allbsd.org (8.14.5/8.14.5) with ESMTP id r03NgK2s095238; Fri, 4 Jan 2013 08:42:21 +0900 (JST) (envelope-from hrs@FreeBSD.org) Date: Fri, 04 Jan 2013 08:41:54 +0900 (JST) Message-Id: <20130104.084154.34484659539126409.hrs@allbsd.org> To: gjb@FreeBSD.org Subject: Re: svn commit: r309908 - head/textproc/docproj From: Hiroki Sato In-Reply-To: <201301032304.r03N40Mp002548@svn.freebsd.org> References: <201301032304.r03N40Mp002548@svn.freebsd.org> X-PGPkey-fingerprint: BDB3 443F A5DD B3D0 A530 FFD7 4F2C D3D8 2793 CF2D X-Mailer: Mew version 6.5 on Emacs 23.4 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Multipart/Signed; protocol="application/pgp-signature"; micalg=pgp-sha1; boundary="--Security_Multipart(Fri_Jan__4_08_41_54_2013_057)--" Content-Transfer-Encoding: 7bit X-Virus-Scanned: clamav-milter 0.97.4 at gatekeeper.allbsd.org X-Virus-Status: Clean X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (mail.allbsd.org [133.31.130.32]); Fri, 04 Jan 2013 08:42:32 +0900 (JST) X-Spam-Status: No, score=-98.1 required=13.0 tests=CONTENT_TYPE_PRESENT, ONLY1HOPDIRECT,SAMEHELOBY2HOP,USER_IN_WHITELIST autolearn=no version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on gatekeeper.allbsd.org Cc: svn-ports-head@FreeBSD.org, svn-ports-all@FreeBSD.org, ports-committers@FreeBSD.org X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Jan 2013 23:42:41 -0000 ----Security_Multipart(Fri_Jan__4_08_41_54_2013_057)-- Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Glen Barber wrote in <201301032304.r03N40Mp002548@svn.freebsd.org>: gj> Author: gjb gj> Date: Thu Jan 3 23:04:00 2013 gj> New Revision: 309908 gj> URL: http://svnweb.freebsd.org/changeset/ports/309908 gj> gj> Log: gj> Unset WITH_JADETEX if not otherwise specified. gj> gj> PR: ports/174952 gj> Submitted by: markj gj> Approved by: doceng (implicit), eadler (mentor) gj> gj> Modified: gj> head/textproc/docproj/Makefile gj> gj> Modified: head/textproc/docproj/Makefile gj> ============================================================================== gj> --- head/textproc/docproj/Makefile Thu Jan 3 21:59:30 2013 (r309907) gj> +++ head/textproc/docproj/Makefile Thu Jan 3 23:04:00 2013 (r309908) gj> @@ -53,7 +53,7 @@ RUN_DEPENDS+= jade:${PORTSDIR}/textproc/ gj> .if defined(JADETEX) gj> WITH_JADETEX= ${JADETEX} gj> .endif gj> -WITH_JADETEX?= gj> +WITH_JADETEX?= no gj> gj> .if defined(PACKAGE_BUILDING) gj> WITH_JADETEX= yes Please revert this and convert it to OPTIONS_DEFINE instead. WITH_JADETEX=no by default makes explanations in files/JADETEX useless and is counterintuitive because a docproj package for releases has been built with WITH_JADETEX=yes for a long time. Some more clean-ups are needed for consistency, but simply setting "no" by default is still problematic and solves nothing IMO. -- Hiroki ----Security_Multipart(Fri_Jan__4_08_41_54_2013_057)-- Content-Type: application/pgp-signature Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (FreeBSD) iEYEABECAAYFAlDmF0IACgkQTyzT2CeTzy2hcwCgiORqE5gnzDXN+YpBjK05sEat 9lQAn089fT6PgcGB6LeGtQyBPZCpnFK9 =F3tN -----END PGP SIGNATURE----- ----Security_Multipart(Fri_Jan__4_08_41_54_2013_057)----