Date: Fri, 04 Jan 2013 08:41:54 +0900 (JST) From: Hiroki Sato <hrs@FreeBSD.org> To: gjb@FreeBSD.org Cc: svn-ports-head@FreeBSD.org, svn-ports-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: svn commit: r309908 - head/textproc/docproj Message-ID: <20130104.084154.34484659539126409.hrs@allbsd.org> In-Reply-To: <201301032304.r03N40Mp002548@svn.freebsd.org> References: <201301032304.r03N40Mp002548@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
----Security_Multipart(Fri_Jan__4_08_41_54_2013_057)-- Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Glen Barber <gjb@FreeBSD.org> wrote in <201301032304.r03N40Mp002548@svn.freebsd.org>: gj> Author: gjb gj> Date: Thu Jan 3 23:04:00 2013 gj> New Revision: 309908 gj> URL: http://svnweb.freebsd.org/changeset/ports/309908 gj> gj> Log: gj> Unset WITH_JADETEX if not otherwise specified. gj> gj> PR: ports/174952 gj> Submitted by: markj gj> Approved by: doceng (implicit), eadler (mentor) gj> gj> Modified: gj> head/textproc/docproj/Makefile gj> gj> Modified: head/textproc/docproj/Makefile gj> ============================================================================== gj> --- head/textproc/docproj/Makefile Thu Jan 3 21:59:30 2013 (r309907) gj> +++ head/textproc/docproj/Makefile Thu Jan 3 23:04:00 2013 (r309908) gj> @@ -53,7 +53,7 @@ RUN_DEPENDS+= jade:${PORTSDIR}/textproc/ gj> .if defined(JADETEX) gj> WITH_JADETEX= ${JADETEX} gj> .endif gj> -WITH_JADETEX?= gj> +WITH_JADETEX?= no gj> gj> .if defined(PACKAGE_BUILDING) gj> WITH_JADETEX= yes Please revert this and convert it to OPTIONS_DEFINE instead. WITH_JADETEX=no by default makes explanations in files/JADETEX useless and is counterintuitive because a docproj package for releases has been built with WITH_JADETEX=yes for a long time. Some more clean-ups are needed for consistency, but simply setting "no" by default is still problematic and solves nothing IMO. -- Hiroki ----Security_Multipart(Fri_Jan__4_08_41_54_2013_057)-- Content-Type: application/pgp-signature Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (FreeBSD) iEYEABECAAYFAlDmF0IACgkQTyzT2CeTzy2hcwCgiORqE5gnzDXN+YpBjK05sEat 9lQAn089fT6PgcGB6LeGtQyBPZCpnFK9 =F3tN -----END PGP SIGNATURE----- ----Security_Multipart(Fri_Jan__4_08_41_54_2013_057)----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130104.084154.34484659539126409.hrs>