From owner-dev-commits-src-all@freebsd.org Wed Jun 2 05:58:53 2021 Return-Path: Delivered-To: dev-commits-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 8442763B58E; Wed, 2 Jun 2021 05:58:53 +0000 (UTC) (envelope-from pfg@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4FvyyP3D1sz3rdt; Wed, 2 Jun 2021 05:58:53 +0000 (UTC) (envelope-from pfg@FreeBSD.org) Received: from [192.168.0.12] (unknown [181.51.107.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) (Authenticated sender: pfg) by smtp.freebsd.org (Postfix) with ESMTPSA id 637BB1C1B; Wed, 2 Jun 2021 05:58:52 +0000 (UTC) (envelope-from pfg@FreeBSD.org) Subject: Re: git: 5a20c351ea45 - main - [skip ci] add a CODEOWNERS file To: Alexey Dokuchaev , Alan Somers Cc: Jessica Clarke , Warner Losh , Ed Maste , src-committers , dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org References: <202105302249.14UMnbcl094541@gitrepo.freebsd.org> <0434E9D2-B0AA-4B5E-942A-A393A83DFFD1@freebsd.org> From: Pedro Giffuni Organization: FreeBSD Message-ID: Date: Wed, 2 Jun 2021 00:58:50 -0500 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.10.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-BeenThere: dev-commits-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Jun 2021 05:58:53 -0000 On 01/06/2021 01:56, Alexey Dokuchaev wrote: > On Mon, May 31, 2021 at 01:50:16PM -0600, Alan Somers wrote: >> On Mon, May 31, 2021 at 1:39 PM Jessica Clarke wrote: >>> ... >>> >>> A hypothetical .gitlab/CODEOWNERS would be checked in as a generated >>> file, if that was unclear. Otherwise I'm not sure I understand your >>> first point? >> There's no need to generate anything. Both github and gitlab support a >> CODEOWNERS file in the project's root. Let's just move it there. We can >> delete the old MAINTAINERS, too, once all of its entries have been >> converted. > Why delete *our* correctly named MAINTAINERS? Tomorrow GH or GL could > decide that "pwning" something bears unnecessary and potentially offending > connotations and break the scheme. I would argue that the list of MAINTAINERS file has basically nothing to do with building FreeBSD so it is currently misplaced. > They want CODEOWNERS now? Fine, all it takes is a simple script to parse > MAINTAINERS and generate CODEOWNERS file they want. Once/if this changes, > we'd easily adapt. CODEOWNERS became the de-facto standard, there's nothing special about MAINTAINERS that justifies the need for a script. Do we really need a bikeshed to determine the name of a file? Pedro.