Date: Mon, 24 Jun 2019 20:37:14 +0200 From: Mathieu Arnold <mat@FreeBSD.org> To: Yuri <yuri@freebsd.org> Cc: Eugene Grosbein <eugen@grosbein.net>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r504998 - head/sysutils/daggy Message-ID: <20190624183714.t2vp7lfq5vtqypit@atuin.in.mat.cc> In-Reply-To: <4cf7b775-6b22-4f31-04ae-535266d156ed@freebsd.org> References: <201906240148.x5O1m1iu065694@repo.freebsd.org> <8288772d-191f-1ad1-58e3-afe01a2a7ccb@grosbein.net> <4cf7b775-6b22-4f31-04ae-535266d156ed@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--qcdyubbitgtgyjo6 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Jun 23, 2019 at 07:22:55PM -0700, Yuri wrote: > On 2019-06-23 18:55, Eugene Grosbein wrote: > > > build > > Yes, it's obvious that you added compiler:c++17-lang. > > It's not obvious what problem does it solve (if it does) and this commi= t log record > > would be right place to describe it:-) > >=20 > >=20 >=20 > I thought that this was also obvious. >=20 > When compilation flags contain the c++17 requirement, gcc-based systems > usually break, and this serves to prevent this. In a commit message, what is important is why things are done, the what is obvious and can be seen by looking at the diff, the why is lost if not recorded in there. --=20 Mathieu Arnold --qcdyubbitgtgyjo6 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAABCgB9FiEEOraXidLtEhBkQLpbOkUW81GDzkgFAl0RGFlfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNB QjY5Nzg5RDJFRDEyMTA2NDQwQkE1QjNBNDUxNkYzNTE4M0NFNDgACgkQOkUW81GD zkin2hAAnDFV+h2JqydlsuY1tYpIoERwsBHeklpoQ4pNAFPvK4sPE+rdVF6Rumjq SR6nZ68YfGK47eJB5jSArebkBatZ2BIU+GvLLMcDHetkLN1cVpVLmRtb7pLjHbJk qDQgtdW0zU3DhFV0DVW0bD/IaZGdKcXFV0phYHlDFdkGawrCNqhdImgREKHN8S0W n8oTutBzQ+y0q8nzTMHjPiKyDULAHvw0IGdm27otNaMdasoMIRD3o3GirrDXRp+0 nEQsZEzmAHglKuoCSj9cxqzFQfDDJrTkHcZJkIU97Q64BDm5hOXUc3UgkX3dJEeO 3np6zATYCVf/4/tomMZ+3K4oUsMFIfsChmsOidC6IH8qs0JnunR6L8GHvaNFxSDb YpOPlqQ8NYFE4TuJ2ojgSbLw8LrbFRZiA2+PQYaLWlaHEu+YcKdnKNSiIb+l4TCe a35FLNm2xeWYXX/qHaSMafzE/w443dBmGLfin/x98znJ7qsHvLEg0oZjJ08ORWRO 9ZXCizzBOvvicXax4+VCTawemkqUXlCviS7ojkTqgG79JB88POrBOQUsIBmXrKAQ JQe/0n6rGd9yRkVjEkKif5NFkSiDg3V/SCJlX/Gn13Z+9qWRUOa3brNnkCQdm0yW kjP1dk6rOe2VxdEbtei/SMWpdX7+BXfK3FJ1iFMdrR+aqiHhSzE= =oE0o -----END PGP SIGNATURE----- --qcdyubbitgtgyjo6--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20190624183714.t2vp7lfq5vtqypit>