From owner-freebsd-ports Fri Mar 1 09:16:32 1996 Return-Path: owner-ports Received: (from root@localhost) by freefall.freebsd.org (8.7.3/8.7.3) id JAA25459 for ports-outgoing; Fri, 1 Mar 1996 09:16:32 -0800 (PST) Received: from veda.is (ubiq.veda.is [193.4.230.60]) by freefall.freebsd.org (8.7.3/8.7.3) with ESMTP id JAA25452 for ; Fri, 1 Mar 1996 09:16:24 -0800 (PST) Received: (from adam@localhost) by veda.is (8.7.4/8.7.3) id RAA03672; Fri, 1 Mar 1996 17:15:37 GMT From: Adam David Message-Id: <199603011715.RAA03672@veda.is> Subject: Re: doc directory To: asami@cs.berkeley.edu (Satoshi Asami) Date: Fri, 1 Mar 1996 17:15:37 +0000 (GMT) Cc: chuckr@Glue.umd.edu, thomas@ghpc8.ihf.rwth-aachen.de, freebsd-ports@freebsd.org In-Reply-To: <199602281159.DAA00921@silvia.HIP.Berkeley.EDU> from Satoshi Asami at "Feb 28, 96 03:59:29 am" X-Mailer: ELM [version 2.4ME+ PL10 (25)] MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-ports@freebsd.org Precedence: bulk [Chuck Robey] > * I wanted the change, too. From what I understood (and I could have been > * wrong) Satoshi was telling me if I wanted such a thing, code it in each > * ports makefile, that it wasn't needed to change bsd.port.mk. I > * disagreed, but I don't trust myself to make changes in bsd.port.mk (what > * a tangle!) so I let it lie. [Satoshi Asami] > The reason why I don't see the necessity to add a new variable for > this is because we need to put the explicit directory name in > pkg/PLIST (no variable substitutions here) anyway. pkg/PLIST.src could contain variables for expansion into PLIST, but this mechanism does not currently exist in bsd.port.mk. > In a nutshell, what I was thinking was: > > (1) Add "share/doc" to /etc/mtree/BSD.local.dist so that the directory > is created by mtree Yes, this is what I was suggesting, and there seems to be agreement that share/doc is preferable to plain doc. Please may I commit this now? :) > (2) Porters will add a post-install target that will create > ${PREFIX}/share/doc/${PKGNAME} and copy doc files in there > > (3) Also, add "share/doc/${PKGNAME}/${FILES}" in pkg/PLIST (note > ${PKGNAME} and ${FILES} should be substituted by the porter) Looks reasonable. Another good reason to keep it out of bsd.port.mk is that ${DISTNAME} and ${PKGNAME} usually carry a version number, but ${DOCDIR} could be something else entirely (for instance without the version number, or simply ${PREFIX}/share/doc). Actually, if there is to be a ${DOCDIR} then perhaps the most sensible default would be ${PREFIX}/share/doc, and recommend in the guidelines to change it to something more appropriate if necessary. -- Adam David