From owner-freebsd-bugs@FreeBSD.ORG Tue Jul 7 08:50:01 2009 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 49E761065673 for ; Tue, 7 Jul 2009 08:50:01 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 235058FC0A for ; Tue, 7 Jul 2009 08:50:01 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id n678o0br084872 for ; Tue, 7 Jul 2009 08:50:00 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.3/8.14.3/Submit) id n678o0si084871; Tue, 7 Jul 2009 08:50:00 GMT (envelope-from gnats) Resent-Date: Tue, 7 Jul 2009 08:50:00 GMT Resent-Message-Id: <200907070850.n678o0si084871@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Anonymous Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D5C32106566C for ; Tue, 7 Jul 2009 08:45:48 +0000 (UTC) (envelope-from swell.k@gmail.com) Received: from mail-fx0-f218.google.com (mail-fx0-f218.google.com [209.85.220.218]) by mx1.freebsd.org (Postfix) with ESMTP id 599FA8FC14 for ; Tue, 7 Jul 2009 08:45:48 +0000 (UTC) (envelope-from swell.k@gmail.com) Received: by fxm18 with SMTP id 18so4006941fxm.43 for ; Tue, 07 Jul 2009 01:45:47 -0700 (PDT) Received: by 10.103.172.9 with SMTP id z9mr3184702muo.58.1246956346966; Tue, 07 Jul 2009 01:45:46 -0700 (PDT) Received: from localhost (95-24-86-242.broadband.corbina.ru [95.24.86.242]) by mx.google.com with ESMTPS id n10sm4068756mue.47.2009.07.07.01.45.45 (version=TLSv1/SSLv3 cipher=RC4-MD5); Tue, 07 Jul 2009 01:45:45 -0700 (PDT) Message-Id: <86k52k2866.fsf@gmail.com> Date: Tue, 07 Jul 2009 12:45:21 +0400 From: Anonymous To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: Subject: kern/136409: [xl] doesn't compile with TX checksumming enabled X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Jul 2009 08:50:01 -0000 >Number: 136409 >Category: kern >Synopsis: [xl] doesn't compile with TX checksumming enabled >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Tue Jul 07 08:50:00 UTC 2009 >Closed-Date: >Last-Modified: >Originator: Anonymous >Release: FreeBSD 8.0-CURRENT amd64 >Organization: >Environment: System: FreeBSD luffy 8.0-CURRENT FreeBSD 8.0-CURRENT #0 r195403M: Sun Jul 5 09:49:17 UTC 2009 root@luffy:/usr/obj/usr/src/sys/PHOENIX amd64 >Description: sys/dev/xl/if_xl.c have this --- begin if_xl.c /* * TX Checksumming is disabled by default for two reasons: * - TX Checksumming will occasionally produce corrupt packets * - TX Checksumming seems to reduce performance * * Only 905B/C cards were reported to have this problem, it is possible * that later chips _may_ be immune. */ #define XL905B_TXCSUM_BROKEN 1 #ifdef XL905B_TXCSUM_BROKEN #define XL905B_CSUM_FEATURES 0 #else #define XL905B_CSUM_FEATURES (CSUM_IP | CSUM_TCP | CSUM_UDP) #endif --- end if_xl.c According to above comment to enable TX checksumming one should just remove line `#define XL905B_TXCSUM_BROKEN 1'. But doing so breaks compilation. >How-To-Repeat: $ sed -i '.bak' '/define[[:space:]]*XL905B_TXCSUM_BROKEN/d' /sys/dev/xl/if_xl.c $ make depend all -C/sys/modules/xl @ -> /usr/src/sys machine -> /usr/src/sys/amd64/include awk -f @/tools/makeobjops.awk @/kern/device_if.m -h awk -f @/tools/makeobjops.awk @/kern/bus_if.m -h awk -f @/tools/makeobjops.awk @/dev/pci/pci_if.m -h awk -f @/tools/makeobjops.awk @/dev/mii/miibus_if.m -h rm -f .depend mkdep -f .depend -a -nostdinc -D_KERNEL -DKLD_MODULE -I. -I@ -I@/contrib/altq /usr/src/sys/modules/xl/../../dev/xl/if_xl.c Warning: Object directory not changed from original /usr/src/sys/modules/xl cc -O2 -pipe -fno-strict-aliasing -Werror -D_KERNEL -DKLD_MODULE -nostdinc -I. -I@ -I@/contrib/altq -finline-limit=8000 --param inline-unit-growth=100 --param large-function-growth=1000 -fno-common -fno-omit-frame-pointer -mcmodel=kernel -mno-red-zone -mfpmath=387 -mno-sse -mno-sse2 -mno-sse3 -mno-mmx -mno-3dnow -msoft-float -fno-asynchronous-unwind-tables -ffreestanding -fstack-protector -std=iso9899:1999 -fstack-protector -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual -Wundef -Wno-pointer-sign -fformat-extensions -c /usr/src/sys/modules/xl/../../dev/xl/if_xl.c /usr/src/sys/modules/xl/../../dev/xl/if_xl.c: In function 'xl_encap': /usr/src/sys/modules/xl/../../dev/xl/if_xl.c:2473: error: request for member 'M_dat' in something not a structure or union /usr/src/sys/modules/xl/../../dev/xl/if_xl.c:2474: error: request for member 'M_dat' in something not a structure or union /usr/src/sys/modules/xl/../../dev/xl/if_xl.c:2476: error: request for member 'M_dat' in something not a structure or union /usr/src/sys/modules/xl/../../dev/xl/if_xl.c:2478: error: request for member 'M_dat' in something not a structure or union *** Error code 1 Stop in /usr/src/sys/modules/xl. >Fix: >Release-Note: >Audit-Trail: >Unformatted: