From owner-freebsd-hackers@FreeBSD.ORG Wed Mar 12 00:20:08 2014 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id B9990416 for ; Wed, 12 Mar 2014 00:20:08 +0000 (UTC) Received: from mail-pd0-f177.google.com (mail-pd0-f177.google.com [209.85.192.177]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 8F6C2878 for ; Wed, 12 Mar 2014 00:20:08 +0000 (UTC) Received: by mail-pd0-f177.google.com with SMTP id g10so279385pdj.22 for ; Tue, 11 Mar 2014 17:20:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=Du5MxGV2v+QHDOpwUy0XfNVFhUvXthVt/kcMvdGWJSk=; b=cLNN+9eS2X6BN2fpGnOKO9QyVSAazViZfwK5TZAEJzHu/vGvSZaBpf8qAJLhUi4+vK P0csRklenS0C2azU0WlnRpLo3ap25VaLuc/DY+GocVR8MH+Qfn1XDEm71e9Ru3OnPriA bB03khbhOy2RF7f9MFgrof+n3qb+h4LXCDjzdtSk/o5muDW+AruJnH5u35i0GL3/AcSb WoT6W/GuAXGbvG6Lgag5xKYD19fz1A0/Rxamq2PiL3iYbk4KLIby5DVZqSgd4jxvzEAU +bm2aEbNiE9JNO3c+4C0TzSdAN1bHlWLy1tNvkm6yD++amnkNsujc+8YrxiWKsnjKbnz W5KQ== X-Gm-Message-State: ALoCoQn24TiBYZF6No/+NvJlY/a/LFPfzgbQWfm8EH0NfPeTRBJ6FTqH7x388/EjZf/7dBKM0Srh X-Received: by 10.68.229.164 with SMTP id sr4mr1171574pbc.82.1394583608114; Tue, 11 Mar 2014 17:20:08 -0700 (PDT) Received: from cmeyer.west.isilon.com (c-67-182-131-225.hsd1.wa.comcast.net. [67.182.131.225]) by mx.google.com with ESMTPSA id jd5sm1276051pbb.18.2014.03.11.17.20.06 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 11 Mar 2014 17:20:07 -0700 (PDT) From: Conrad Meyer To: freebsd-hackers@freebsd.org Subject: [PATCH 4/5] dev/cpuctl: cpuctl_modevent: Use correct type for sizeof() in malloc() Date: Tue, 11 Mar 2014 17:19:42 -0700 Message-Id: <1394583583-19023-5-git-send-email-conrad.meyer@isilon.com> X-Mailer: git-send-email 1.8.5.3 In-Reply-To: <1394583583-19023-1-git-send-email-conrad.meyer@isilon.com> References: <1394583583-19023-1-git-send-email-conrad.meyer@isilon.com> X-Mailman-Approved-At: Wed, 12 Mar 2014 02:10:00 +0000 Cc: Conrad Meyer , Jeffrey Roberson X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 12 Mar 2014 00:20:08 -0000 Both types are pointers, so this isn't a big deal. But Clang static analysis reports it, so we might as well correct it (and it's the right thing to do.) Signed-off-by: Conrad Meyer --- sys/dev/cpuctl/cpuctl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sys/dev/cpuctl/cpuctl.c b/sys/dev/cpuctl/cpuctl.c index 317fc08..94fa62a 100644 --- a/sys/dev/cpuctl/cpuctl.c +++ b/sys/dev/cpuctl/cpuctl.c @@ -510,8 +510,8 @@ cpuctl_modevent(module_t mod __unused, int type, void *data __unused) } if (bootverbose) printf("cpuctl: access to MSR registers/cpuid info.\n"); - cpuctl_devs = (struct cdev **)malloc(sizeof(void *) * mp_ncpus, - M_CPUCTL, M_WAITOK | M_ZERO); + cpuctl_devs = malloc(sizeof(*cpuctl_devs) * mp_ncpus, M_CPUCTL, + M_WAITOK | M_ZERO); if (cpuctl_devs == NULL) { DPRINTF("[cpuctl,%d]: cannot allocate memory\n", __LINE__); -- 1.8.5.3