From owner-svn-src-all@freebsd.org Mon Feb 12 15:58:57 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 60038F03501; Mon, 12 Feb 2018 15:58:57 +0000 (UTC) (envelope-from joerg@bec.de) Received: from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net [IPv6:2001:4b98:c:538::196]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id F2A1C7BDB9; Mon, 12 Feb 2018 15:58:56 +0000 (UTC) (envelope-from joerg@bec.de) Received: from britannica.bec.de (p200300D2ABCCC4104639C4FFFE599710.dip0.t-ipconnect.de [IPv6:2003:d2:abcc:c410:4639:c4ff:fe59:9710]) (Authenticated sender: joerg@bec.de) by relay4-d.mail.gandi.net (Postfix) with ESMTPSA id 0A3AF172677; Mon, 12 Feb 2018 16:58:46 +0100 (CET) Date: Mon, 12 Feb 2018 16:57:49 +0100 From: Joerg Sonnenberger To: Warner Losh Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r329164 - in head: include sys/amd64/include sys/i386/include sys/mips/include sys/powerpc/include sys/sparc64/include Message-ID: <20180212155749.GA27160@britannica.bec.de> References: <201802121448.w1CEmEUX082701@repo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201802121448.w1CEmEUX082701@repo.freebsd.org> User-Agent: Mutt/1.9.0 (2017-09-02) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Feb 2018 15:58:57 -0000 On Mon, Feb 12, 2018 at 02:48:14PM +0000, Warner Losh wrote: > Author: imp > Date: Mon Feb 12 14:48:14 2018 > New Revision: 329164 > URL: https://svnweb.freebsd.org/changeset/base/329164 > > Log: > We don't support gcc < 4.2.1, so varargs.h now is just #error > always. Unifdef for versions prior to 4.2.1 and remove now-unused > header files. In my experience it is better to really drop it. Keeping the header with an #error is just creating *more* pain than having no header at all. Joerg