From owner-freebsd-stable@freebsd.org Tue Dec 15 21:29:43 2015 Return-Path: Delivered-To: freebsd-stable@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 61E0BA48D1E for ; Tue, 15 Dec 2015 21:29:43 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qk0-x235.google.com (mail-qk0-x235.google.com [IPv6:2607:f8b0:400d:c09::235]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 236E11DD1 for ; Tue, 15 Dec 2015 21:29:42 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-qk0-x235.google.com with SMTP id t125so34900605qkh.3 for ; Tue, 15 Dec 2015 13:29:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=9UBmX7kDbNTqOX8VfMWMs7fOD9U5mdRACkPlmMSHEYw=; b=DYMdwky+6V0Kyziuh83ikIyA5OFYMleZv2GJQDoe32gYPmxTqRmpcOvjx9GX7CK5iu IjvAvcZVicUeLappOgvZa4R0lRVMA1jRr1aWwO+JUgNtfLC/WW1rUn4qvuMg6lZKUwPD nrva+DRl6W5iqu1hZcDuBe2uJGgN0AgS4AmwRrlsP6YuO26SubSHuALvFuX7SKWVD662 4FxsyC+sJUpQF61IeJPDW3UdLsTp287NPUg6pqZQgXiyBvKg048FdxmQsyeLsWGolMR5 +CBud2xdKqK+oGcUP9RasyWNdhouJKlvYBM6ZTq7DMYv+IVKP1/YLKLXUhMZ7Wjx90Yh NBjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=9UBmX7kDbNTqOX8VfMWMs7fOD9U5mdRACkPlmMSHEYw=; b=MnTXwp9lK/Je5H6qVzvudERZtJcRqv6tcGr/Kcix9o2pp+JY6GNKxGuzunQUsySjJK JuoaPUq/U9JAD2pjmF8/qaciB/Ml532HQrop2DFSRZM2emLKWoD1zbL8NTOGfDOd+ImQ 381OX1m49aGyGxrxlCGdiDY9gCLIl2NtQDFQbnucbhEDeOw0IEGhYza+7g6PqCoKsWxt 5Z57ePO3lzPNYxW2//klz5MRK/s67Np0Ec8EWK16nraXTMoDXsWCmv3G+u/GwwxBQque iAJ2OGAI26MIea6+F+IWOxde+QPWrHE10ogntkGPwX+QKRTYszZQuQeVLt6MCs+fNx5X oYPg== X-Gm-Message-State: ALoCoQkDh13Ckc+RGoOGmyOpRQeIjDha1Q886EMWNJ7HnalvZChFW5vv4O+rzerJLt7wbNxUpDa54I7taeJ07DzJ8cemB76uOg== MIME-Version: 1.0 X-Received: by 10.55.81.11 with SMTP id f11mr54097561qkb.10.1450214981763; Tue, 15 Dec 2015 13:29:41 -0800 (PST) Sender: wlosh@bsdimp.com Received: by 10.140.27.181 with HTTP; Tue, 15 Dec 2015 13:29:41 -0800 (PST) X-Originating-IP: [173.164.135.226] In-Reply-To: <04FF06C6-4A84-436E-B9A7-5DDA2E7DFA48@gmail.com> References: <20151214165111.GA70582@jarvis.whl> <566EF46A.8080704@FreeBSD.org> <20151214165858.GA76268@jarvis.whl> <566FF870.7030106@FreeBSD.org> <04FF06C6-4A84-436E-B9A7-5DDA2E7DFA48@gmail.com> Date: Tue, 15 Dec 2015 13:29:41 -0800 X-Google-Sender-Auth: fmBtv2_6m7TsNLx__yXodh6PCCA Message-ID: Subject: Re: make tinderbox broken with LINT-NOINET on ref10-amd64.freebsd.org (if_gif compilation issues) From: Warner Losh To: NGie Cooper Cc: "Andrey V. Elsukov" , Mariusz Zaborski , FreeBSD-Stable ML , Warner Losh Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.20 X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Dec 2015 21:29:43 -0000 On Tue, Dec 15, 2015 at 11:48 AM, NGie Cooper wrote= : > > > On Dec 15, 2015, at 03:24, Andrey V. Elsukov wrote: > > > > On 14.12.15 19:58, Mariusz Zaborski wrote: > >> On Mon, Dec 14, 2015 at 07:55:06PM +0300, Andrey V. Elsukov wrote: > >>> On 14.12.15 19:51, Mariusz Zaborski wrote: > >>>> On Mon, Dec 14, 2015 at 06:31:52AM -0800, NGie Cooper wrote: > >>>>> Hi Andrey, Just a heads up that LINT-NOINET seems to be broken on > >>>>> amd64/i386 with if_gif(4) on stable/10. Could you please fix this? > >>>>> Thanks, -NGie > >>>> Hi, > >>>> > >>>> I already found the problem we need to MFC r276224 and r277130. > >>> > >>> I don't think r277130 is related to this problem. > >>> I have this patch and I'm trying to build with them. > >> Not with this but after fixing r276224 it will crash in other place > which > >> r277130 is fixing. :) > > > > Actually, I don't think that my patch will work correctly. > > opt_inet.h can contain several options in addition to INET. In such cas= e > > the expression > > > > OPT_INET!=3D cat ${KERNBUILDDIR}/opt_inet.h; echo > > .if empty(OPT_INET) > > > > will always be true. Are you sure merging of r276224 it works as > expected? > > > > Probably, this patch will work correctly: > > Would it be a good idea to do: > > MK_INET_SUPPORT?=3Dno > > instead of: > > MK_INET_SUPPORT=3Dno > > , in the event that someone wanted if_gif support but hadn=E2=80=99t conf= igured > their kernel yet? > No. If your kernel doesn't have INET support, but the if_gif module does, then it won't load. Warner