From owner-cvs-all Sun Jul 22 1:32:33 2001 Delivered-To: cvs-all@freebsd.org Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16]) by hub.freebsd.org (Postfix) with ESMTP id 74AB137B405; Sun, 22 Jul 2001 01:32:28 -0700 (PDT) (envelope-from bde@zeta.org.au) Received: from bde.zeta.org.au (bde.zeta.org.au [203.2.228.102]) by mailman.zeta.org.au (8.9.3/8.8.7) with ESMTP id SAA21475; Sun, 22 Jul 2001 18:32:26 +1000 Date: Sun, 22 Jul 2001 18:29:15 +1000 (EST) From: Bruce Evans X-Sender: bde@besplex.bde.org To: Assar Westerlund Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern makeobjops.pl In-Reply-To: <200107211712.f6LHCjr88023@freefall.freebsd.org> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Sat, 21 Jul 2001, Assar Westerlund wrote: > assar 2001/07/21 10:12:45 PDT > > Modified files: > sys/kern makeobjops.pl > Log: > add (for __unused and such) This is bogus. From style(9): Kernel include files (i.e. sys/*.h) come first; normally, you'll need OR , but not both! includes , and it's okay to depend on that. Including the implementation detail ``'' in non-headers is even more bogus than including both and . Only 16 .c files in the entire kernel do it. It is unused in ll 16 of those (it was used in NetBSD in 6 of those to expand NetBSD rcsid macros). Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message