From owner-freebsd-bugs@FreeBSD.ORG  Mon Sep 24 17:00:14 2007
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 7DD9016A46C
	for <freebsd-bugs@hub.freebsd.org>;
	Mon, 24 Sep 2007 17:00:14 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id 8DAD013C4B8
	for <freebsd-bugs@hub.freebsd.org>;
	Mon, 24 Sep 2007 17:00:14 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.1/8.14.1) with ESMTP id l8OH0Ekj089207
	for <freebsd-bugs@freefall.freebsd.org>; Mon, 24 Sep 2007 17:00:14 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.1/8.14.1/Submit) id l8OH0EVO089206;
	Mon, 24 Sep 2007 17:00:14 GMT (envelope-from gnats)
Date: Mon, 24 Sep 2007 17:00:14 GMT
Message-Id: <200709241700.l8OH0EVO089206@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.org
From: Eugene Grosbein <eugen@grosbein.pp.ru>
Cc: 
Subject: Re: kern/116536: [fdc] [patch] fdc(4) does not respect
	hint.fd.0.flags from device.hints
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: Eugene Grosbein <eugen@grosbein.pp.ru>
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 24 Sep 2007 17:00:14 -0000

The following reply was made to PR kern/116536; it has been noted by GNATS.

From: Eugene Grosbein <eugen@grosbein.pp.ru>
To: bug-followup@freebsd.org
Cc: Bruce Evans <brde@optusnet.com.au>
Subject: Re: kern/116536: [fdc] [patch] fdc(4) does not respect hint.fd.0.flags from device.hints
Date: Tue, 25 Sep 2007 00:56:54 +0800

 On Sat, 22 Sep 2007, Bruce Evans wrote:
 
 > fd->flags has nothing to do with the device flags.  This copy of the device
 > flags gets clobbered later when fd->flags is used for more-dynamic flags.
 
 int has (at least) 32 bits, why not use them?
 It's possible to move values for user-settable flags 
 (that are broken anyway for now) so that they do not globber
 with more-dynamic flags. What's the point in calls to device_get_flags()
 all the way?
 
 Eugene Grosbein