From owner-svn-src-head@freebsd.org Sat Oct 20 21:04:49 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2C097FF5C8B; Sat, 20 Oct 2018 21:04:49 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: from mail-io1-f53.google.com (mail-io1-f53.google.com [209.85.166.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id AE38388F5B; Sat, 20 Oct 2018 21:04:48 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: by mail-io1-f53.google.com with SMTP id y22-v6so424130ioj.13; Sat, 20 Oct 2018 14:04:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:reply-to :from:date:message-id:subject:to:cc; bh=elpSz7FNOfZDP5jwkLdvNDSjhCnpnNrSPs9V4iXRI0M=; b=ganIWs5/5WkyoE6qM+18dUrjYXkSORhulp8IuzlfV8HAk7R6cFSjX2rU4zTEwoj2ja 2KtAN7WbU15K0oUrYc+sJ2gJnc7/0xp3a0ZynoQRBXvO/rTsX9kQtFFGrHqbR6l1rh29 pXbGlQZmpIpwN6KSMBOrEfktZy4GLAR68bDIME1GZer1DgGekofnf48+NnwLqzXGKuXS 0CL0aVxVzW/jSHbyls+xHdMUVSeAV82/F1zBDcnGKEL0/CecmGNTVjebovtyw8gqZIca ZcyhnBaTMt2gUMNDpQY61uK8qvGCIhhsnDVWw8wSAnb+dBTOQ0VaFzGqymZlCq/DwLBL Ty1A== X-Gm-Message-State: AGRZ1gJOOgVgxJnLd9XBtGbe4CPbSkzhM0AgCYZ4WiwOXOMASt7juwS3 HPt31ZfNJL9ib9p/aIjpnshUVpTv X-Google-Smtp-Source: AJdET5fHd2lJfCaybl0DE1ihK6TDHd6LUw+SNG5kCRYTnAYB4IoiuDIqyBj4VrznFQ9xcbyBa5vdmQ== X-Received: by 2002:a6b:cb01:: with SMTP id b1-v6mr6063326iog.23.1540069481594; Sat, 20 Oct 2018 14:04:41 -0700 (PDT) Received: from mail-it1-f169.google.com (mail-it1-f169.google.com. [209.85.166.169]) by smtp.gmail.com with ESMTPSA id j141-v6sm2962116ita.3.2018.10.20.14.04.41 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 20 Oct 2018 14:04:41 -0700 (PDT) Received: by mail-it1-f169.google.com with SMTP id 134-v6so8030249itz.2; Sat, 20 Oct 2018 14:04:41 -0700 (PDT) X-Received: by 2002:a24:a00a:: with SMTP id o10-v6mr5992592ite.32.1540069481022; Sat, 20 Oct 2018 14:04:41 -0700 (PDT) MIME-Version: 1.0 References: <201810201831.w9KIVbtN043921@repo.freebsd.org> In-Reply-To: Reply-To: cem@freebsd.org From: Conrad Meyer Date: Sat, 20 Oct 2018 14:04:29 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r339468 - in head/sys: kern sys To: Ed Schouten Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 20 Oct 2018 21:04:49 -0000 Yep! On Sat, Oct 20, 2018 at 1:49 PM Ed Schouten wrote: > > Op za 20 okt. 2018 om 21:59 schreef Conrad Meyer : > > > Can kdb_active, tp == NULL and panicstr != NULL even occur in this > > > case? tty_info() can only get called in non-degenerate cases, right? > > > > I think you are correct, but I did not want to investigate to confirm. > > This was just the direct, conservative conversion of ttyprintf -> > > putchar. The checks can *probably* be removed. > > If they can, then certain other parts of this change can be reverted > as well (e.g., the addition of cnputsn). > > -- > Ed Schouten