Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 1 Apr 2024 03:31:09 +0800
From:      Po-Chuan Hsieh <sunpoet@freebsd.org>
To:        Daniel Engberg <diizzy@freebsd.org>
Cc:        ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org,  dev-commits-ports-main@freebsd.org
Subject:   Re: git: 1a2f57d29bcc - main - multimedia/libzen: Adjust package version
Message-ID:  <CAMHz58Q9i6jv-%2BAmPYni7MStiL1o3Ez2udPooqwA=0iqjXr7rg@mail.gmail.com>
In-Reply-To: <202403282226.42SMQmaW063083@gitrepo.freebsd.org>
References:  <202403282226.42SMQmaW063083@gitrepo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
--00000000000072870c0614f9ecc1
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Fri, Mar 29, 2024 at 6:26=E2=80=AFAM Daniel Engberg <diizzy@freebsd.org>=
 wrote:

> The branch main has been updated by diizzy:
>
> URL:
> https://cgit.FreeBSD.org/ports/commit/?id=3D1a2f57d29bcc8c5cd27973998909c=
5e519f90457
>
> commit 1a2f57d29bcc8c5cd27973998909c5e519f90457
> Author:     Daniel Engberg <diizzy@FreeBSD.org>
> AuthorDate: 2024-03-28 22:06:52 +0000
> Commit:     Daniel Engberg <diizzy@FreeBSD.org>
> CommitDate: 2024-03-28 22:25:58 +0000
>
>     multimedia/libzen: Adjust package version
>
>     Upstream bundles libzen (named ZenLib upstream) both separately and
>     as a all-in-one bundle with mediainfo (multimedia/mediainfo) releases=
.
>     Libzen do not share the same versioning schema as mediainfo and hence
>     shouldn't use it. Upstream bundles snapshots of libzen however only
>     release versions are tracked (current version is defined as 0.4.41).
>     Current release bundle archive ships the latest commit of libzen
>     available and following Porters Handbook append commit date to
>     release version. Worth noting is that separate version provided
>     on upstream's download page corresponds to the tagged version on
>     GitHub.
>
>     Sources:
>     https://github.com/MediaArea/ZenLib
>     https://mediaarea.net/en/MediaInfo/Download/Source
>
>     PR:             276754
>     Approved by:    portmgr (maintainer timeout, 1+ month)
>

I don't see any patch files for this commit on Bugzilla. The only one is
incorrect and outdated.

---
>  multimedia/libzen/Makefile | 10 ++++++----
>  1 file changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/multimedia/libzen/Makefile b/multimedia/libzen/Makefile
> index 365fa2ba5d98..60cb49bdc993 100644
> --- a/multimedia/libzen/Makefile
> +++ b/multimedia/libzen/Makefile
> @@ -1,10 +1,11 @@
>  PORTNAME=3D      libzen
> -PORTVERSION=3D   24.01.1
> -PORTEPOCH=3D     1
> +DISTVERSION=3D   0.4.41.20240118
> +PORTREVISION=3D  1
>

FYI, since you bumped PORTEPOCH, you don't need to bump PORTREVISION.


> +PORTEPOCH=3D     2
>  CATEGORIES=3D    multimedia
> -MASTER_SITES=3D
> https://mediaarea.net/download/binary/mediainfo/${PORTVERSION}/ \
> +MASTER_SITES=3D
> https://mediaarea.net/download/binary/mediainfo/${UPSTREAM_BUNDLE_VERSION=
}/
> \
>                 LOCAL/sunpoet
> -DISTNAME=3D      MediaInfo_CLI_${PORTVERSION}_GNU_FromSource
> +DISTNAME=3D      MediaInfo_CLI_${UPSTREAM_BUNDLE_VERSION}_GNU_FromSource
>
>  MAINTAINER=3D    sunpoet@FreeBSD.org
>  COMMENT=3D       ZenLib used by MediaInfo and its library
> @@ -19,6 +20,7 @@ USES=3D         compiler:c++11-lang dos2unix libtool
> pathfix tar:xz
>  CONFIGURE_ARGS=3D        --enable-shared --enable-static
>  GNU_CONFIGURE=3D yes
>  INSTALL_TARGET=3D        install-strip
> +UPSTREAM_BUNDLE_VERSION=3D       24.01.1
>  USE_LDCONFIG=3D  yes
>
>  WRKSRC=3D
> ${WRKDIR}/MediaInfo_CLI_GNU_FromSource/ZenLib/Project/GNU/Library
>
>

--00000000000072870c0614f9ecc1
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr">On Fri, Mar 29, 2024 at 6:26=E2=80=AFAM D=
aniel Engberg &lt;<a href=3D"mailto:diizzy@freebsd.org" target=3D"_blank">d=
iizzy@freebsd.org</a>&gt; wrote:<br></div><div class=3D"gmail_quote"><block=
quote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1=
px solid rgb(204,204,204);padding-left:1ex">The branch main has been update=
d by diizzy:<br>
<br>
URL: <a href=3D"https://cgit.FreeBSD.org/ports/commit/?id=3D1a2f57d29bcc8c5=
cd27973998909c5e519f90457" rel=3D"noreferrer" target=3D"_blank">https://cgi=
t.FreeBSD.org/ports/commit/?id=3D1a2f57d29bcc8c5cd27973998909c5e519f90457</=
a><br>
<br>
commit 1a2f57d29bcc8c5cd27973998909c5e519f90457<br>
Author:=C2=A0 =C2=A0 =C2=A0Daniel Engberg &lt;diizzy@FreeBSD.org&gt;<br>
AuthorDate: 2024-03-28 22:06:52 +0000<br>
Commit:=C2=A0 =C2=A0 =C2=A0Daniel Engberg &lt;diizzy@FreeBSD.org&gt;<br>
CommitDate: 2024-03-28 22:25:58 +0000<br>
<br>
=C2=A0 =C2=A0 multimedia/libzen: Adjust package version<br>
<br>
=C2=A0 =C2=A0 Upstream bundles libzen (named ZenLib upstream) both separate=
ly and<br>
=C2=A0 =C2=A0 as a all-in-one bundle with mediainfo (multimedia/mediainfo) =
releases.<br>
=C2=A0 =C2=A0 Libzen do not share the same versioning schema as mediainfo a=
nd hence<br>
=C2=A0 =C2=A0 shouldn&#39;t use it. Upstream bundles snapshots of libzen ho=
wever only<br>
=C2=A0 =C2=A0 release versions are tracked (current version is defined as 0=
.4.41).<br>
=C2=A0 =C2=A0 Current release bundle archive ships the latest commit of lib=
zen<br>
=C2=A0 =C2=A0 available and following Porters Handbook append commit date t=
o<br>
=C2=A0 =C2=A0 release version. Worth noting is that separate version provid=
ed<br>
=C2=A0 =C2=A0 on upstream&#39;s download page corresponds to the tagged ver=
sion on<br>
=C2=A0 =C2=A0 GitHub.<br>
<br>
=C2=A0 =C2=A0 Sources:<br>
=C2=A0 =C2=A0 <a href=3D"https://github.com/MediaArea/ZenLib" rel=3D"norefe=
rrer" target=3D"_blank">https://github.com/MediaArea/ZenLib</a><br>;
=C2=A0 =C2=A0 <a href=3D"https://mediaarea.net/en/MediaInfo/Download/Source=
" rel=3D"noreferrer" target=3D"_blank">https://mediaarea.net/en/MediaInfo/D=
ownload/Source</a><br>
<br>
=C2=A0 =C2=A0 PR:=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0276754<br>
=C2=A0 =C2=A0 Approved by:=C2=A0 =C2=A0 portmgr (maintainer timeout, 1+ mon=
th)<br></blockquote><div><br></div><div>I don&#39;t see any patch=C2=A0file=
s for this commit on Bugzilla. The only one is incorrect and outdated.</div=
><div><br></div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0=
px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
---<br>
=C2=A0multimedia/libzen/Makefile | 10 ++++++----<br>
=C2=A01 file changed, 6 insertions(+), 4 deletions(-)<br>
<br>
diff --git a/multimedia/libzen/Makefile b/multimedia/libzen/Makefile<br>
index 365fa2ba5d98..60cb49bdc993 100644<br>
--- a/multimedia/libzen/Makefile<br>
+++ b/multimedia/libzen/Makefile<br>
@@ -1,10 +1,11 @@<br>
=C2=A0PORTNAME=3D=C2=A0 =C2=A0 =C2=A0 libzen<br>
-PORTVERSION=3D=C2=A0 =C2=A024.01.1<br>
-PORTEPOCH=3D=C2=A0 =C2=A0 =C2=A01<br>
+DISTVERSION=3D=C2=A0 =C2=A00.4.41.20240118<br>
+PORTREVISION=3D=C2=A0 1<br></blockquote><div><br></div><div>FYI, since you=
 bumped PORTEPOCH, you don&#39;t need to bump PORTREVISION.</div><div>=C2=
=A0</div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8e=
x;border-left:1px solid rgb(204,204,204);padding-left:1ex">
+PORTEPOCH=3D=C2=A0 =C2=A0 =C2=A02<br>
=C2=A0CATEGORIES=3D=C2=A0 =C2=A0 multimedia<br>
-MASTER_SITES=3D=C2=A0 <a href=3D"https://mediaarea.net/download/binary/med=
iainfo/$%7BPORTVERSION%7D/" rel=3D"noreferrer" target=3D"_blank">https://me=
diaarea.net/download/binary/mediainfo/${PORTVERSION}/</a> \<br>
+MASTER_SITES=3D=C2=A0 <a href=3D"https://mediaarea.net/download/binary/med=
iainfo/$%7BUPSTREAM_BUNDLE_VERSION%7D/" rel=3D"noreferrer" target=3D"_blank=
">https://mediaarea.net/download/binary/mediainfo/${UPSTREAM_BUNDLE_VERSION=
}/</a> \<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 LOCAL/sunpoet<br>
-DISTNAME=3D=C2=A0 =C2=A0 =C2=A0 MediaInfo_CLI_${PORTVERSION}_GNU_FromSourc=
e<br>
+DISTNAME=3D=C2=A0 =C2=A0 =C2=A0 MediaInfo_CLI_${UPSTREAM_BUNDLE_VERSION}_G=
NU_FromSource<br>
<br>
=C2=A0MAINTAINER=3D=C2=A0 =C2=A0 sunpoet@FreeBSD.org<br>
=C2=A0COMMENT=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0ZenLib used by MediaInfo and its=
 library<br>
@@ -19,6 +20,7 @@ USES=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0compiler:c++11-l=
ang dos2unix libtool pathfix tar:xz<br>
=C2=A0CONFIGURE_ARGS=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 --enable-shared --enable=
-static<br>
=C2=A0GNU_CONFIGURE=3D yes<br>
=C2=A0INSTALL_TARGET=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 install-strip<br>
+UPSTREAM_BUNDLE_VERSION=3D=C2=A0 =C2=A0 =C2=A0 =C2=A024.01.1<br>
=C2=A0USE_LDCONFIG=3D=C2=A0 yes<br>
<br>
=C2=A0WRKSRC=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ${WR=
KDIR}/MediaInfo_CLI_GNU_FromSource/ZenLib/Project/GNU/Library<br>
<br>
</blockquote></div></div>

--00000000000072870c0614f9ecc1--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAMHz58Q9i6jv-%2BAmPYni7MStiL1o3Ez2udPooqwA=0iqjXr7rg>