From owner-freebsd-mobile Tue Oct 30 9:34:40 2001 Delivered-To: freebsd-mobile@freebsd.org Received: from salmon.maths.tcd.ie (salmon.maths.tcd.ie [134.226.81.11]) by hub.freebsd.org (Postfix) with SMTP id 6C6BA37B401 for ; Tue, 30 Oct 2001 09:34:36 -0800 (PST) Received: from walton.maths.tcd.ie by salmon.maths.tcd.ie with SMTP id ; 30 Oct 2001 17:34:35 +0000 (GMT) To: freebsd-mobile@freebsd.org Subject: Re: Installing 4.4 on sony vaio c1ve from pcga-cd51 cdrom In-Reply-To: Your message of "Tue, 30 Oct 2001 01:10:41 EST." <20011030011041.B10134@pir.net> Date: Tue, 30 Oct 2001 17:34:35 +0000 From: Ian Dowse Message-ID: <200110301734.aa87376@salmon.maths.tcd.ie> Sender: owner-freebsd-mobile@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org In message <20011030011041.B10134@pir.net>, Peter Radcliffe writes: >#6 0xc02326cc in strncpy (dst=0xc6523d00 "ata", src=0x0, n=16) > at ../../libkern/strncpy.c:53 >#7 0xc01d7dd8 in allocate_driver (slt=0xc6241000, desc=0xc6523d00) > at ../../pccard/pccard.c:270 >This make sense to anyone ? There's a comment in the code that explains it: /* * XXX We unwisely assume that the detach code won't run while the * XXX the attach code is attaching. Someone should put some * XXX interlock code. This can happen if probe/attach takes a while * XXX and the user ejects the card, which causes the detach * XXX function to be called. */ strncpy(desc->name, device_get_nameunit(child), sizeof(desc->name)); I guess allocate_driver() could call device_get_children on 'pccarddev' and check if 'child' is among the list. That would cover most cases of the device going away during the call to device_probe_and_attach(). Ian To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-mobile" in the body of the message