From nobody Sun Jan 21 19:16:19 2024 X-Original-To: dev-commits-ports-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4TJ34C62Cxz57YJN; Sun, 21 Jan 2024 19:16:27 +0000 (UTC) (envelope-from mi+t@virtual-estates.net) Received: from symbion.zaytman.com (symbion.zaytman.com [64.112.176.10]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "symbion", Issuer "Narawntapu" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4TJ34C5V1Rz4Z4H; Sun, 21 Jan 2024 19:16:26 +0000 (UTC) (envelope-from mi+t@virtual-estates.net) Authentication-Results: mx1.freebsd.org; none Received: from aldan.narawntapu (pool-100-1-252-187.nwrknj.fios.verizon.net [100.1.252.187]) by symbion.zaytman.com (8.17.1/8.16.1) with ESMTPS id 40LJGM1r033708 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=OK); Sun, 21 Jan 2024 14:16:22 -0500 (EST) (envelope-from mi+t@virtual-estates.net) X-Authentication-Warning: symbion.zaytman.com: Host pool-100-1-252-187.nwrknj.fios.verizon.net [100.1.252.187] claimed to be aldan.narawntapu Received: from [192.168.1.10] (aldan [192.168.1.10]) by aldan.narawntapu (8.17.2/8.17.1) with ESMTP id 40LJGJnn000703; Sun, 21 Jan 2024 14:16:20 -0500 (EST) (envelope-from mi+t@virtual-estates.net) X-Authentication-Warning: aldan.narawntapu: Host aldan [192.168.1.10] claimed to be [192.168.1.10] Content-Type: multipart/alternative; boundary="------------76HxRvGC7aDpBCiWsCdMRUXN" Message-ID: <7ae9295a-0b05-4589-85d9-440ba373707f@virtual-estates.net> Date: Sun, 21 Jan 2024 14:16:19 -0500 List-Id: Commit messages for all branches of the ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-all@freebsd.org X-BeenThere: dev-commits-ports-all@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: git: b430a140c818 - main - net-im/purple-gowhatsapp: add WhatsApp plugin for libpurple Content-Language: en-US To: Daniel Engberg Cc: Kurt Jaeger , ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org References: <202401202030.40KKUApC045320@gitrepo.freebsd.org> <7e07375b-32bc-4778-8977-d87d6e135679@virtual-estates.net> <8ab62f5f-bb62-4633-9d1c-d7a8a8e1fc8a@virtual-estates.net> <13433172-a8cb-494c-a435-fd4d8418a2e6@virtual-estates.net> <21dcca053d36f9bec4005ffb18897f51@mail.infomaniak.com> From: "Mikhail T." In-Reply-To: X-DCC-www.nova53.net-Metrics: aldan.narawntapu 1204; bulk rep Body=5 Fuz1=5 Fuz2=5 rep=43% X-Spam-Status: No, score=-2.9 required=23.7 tests=ALL_TRUSTED,BAYES_00, HTML_MESSAGE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=4.0.0 X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-14) on aldan.narawntapu X-Rspamd-Queue-Id: 4TJ34C5V1Rz4Z4H X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; TAGGED_FROM(0.00)[t]; ASN(0.00)[asn:394548, ipnet:64.112.176.0/24, country:US] This is a multi-part message in MIME format. --------------76HxRvGC7aDpBCiWsCdMRUXN Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit 21.01.24 13:47, Daniel Engberg: > While we all do mistakes I'm asking because it's broken and it's > likely not going to be fixed any time soon. I wonder, how you estimate this likelihood... > In reality it adds noise (which we already have enough of) on lists, > Poudriere builds (because by default we build all ports) takes more > time producing nothing, more time for people to review error logs and > so on. All of this could be silenced with BROKEN, no? > It boils down to my time > your time which usually don't translate > well in team efforts. No, I don't see it boiling down to that. To me it seems like a simple overreaction. So, a newly-added port is broken -- what's the big deal? You'd be right expecting the committer to  examine the error-log himself... It is just computers working -- so the humans, present company included, can do fun things. > Instead of doing the same thing again use Poudriere as you're by know > well aware that it "should" be used and you have been "warned". On the contrary -- as long as the "should" remains quoted, I intend to do the same thing: /commit, what I sincerely believe is working code/. Mat is already convinced, I *must* follow, what you acknowledge is just a recommendation -- on the strength of his creating a rule out of void. Rights not exercised are rights lost, and all that :-) > I would also say that you'd be better off in general asking for > suggestions by creating a PR and or use Phab(ricator) due to quality > reasons (to mention it again, team effort). Believe it or not, I did ask for suggestions before committing -- sending the shar of the would be port to the committers of (because go@FreeBSD.mk is blocked to non-subscribers). Having received no immediate replies, I figured, I'll see, what Poudriere would say -- still don't understand the scale of the blowback... -mi --------------76HxRvGC7aDpBCiWsCdMRUXN Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit
21.01.24 13:47, Daniel Engberg:
While we all do mistakes I'm asking because it's broken and it's likely not going to be fixed any time soon.
I wonder, how you estimate this likelihood...
In reality it adds noise (which we already have enough of) on lists, Poudriere builds (because by default we build all ports) takes more time producing nothing, more time for people to review error logs and so on.
All of this could be silenced with BROKEN, no?
It boils down to my time > your time which usually don't translate well in team efforts.

No, I don't see it boiling down to that. To me it seems like a simple overreaction. So, a newly-added port is broken -- what's the big deal? You'd be right expecting the committer to  examine the error-log himself... It is just computers working -- so the humans, present company included, can do fun things.

Instead of doing the same thing again use Poudriere as you're by know well aware that it "should" be used and you have been "warned".
On the contrary -- as long as the "should" remains quoted, I intend to do the same thing: commit, what I sincerely believe is working code. Mat is already convinced, I must follow, what you acknowledge is just a recommendation -- on the strength of his creating a rule out of void. Rights not exercised are rights lost, and all that :-)
I would also say that you'd be better off in general asking for suggestions by creating a PR and or use Phab(ricator) due to quality reasons (to mention it again, team effort).

Believe it or not, I did ask for suggestions before committing -- sending the shar of the would be port to the committers of <go.mk> (because go@FreeBSD.mk is blocked to non-subscribers). Having received no immediate replies, I figured, I'll see, what Poudriere would say -- still don't understand the scale of the blowback...

-mi

--------------76HxRvGC7aDpBCiWsCdMRUXN--