Date: Sat, 10 Dec 2011 00:02:55 -0200 From: Raphael Kubo da Costa <rakuco@freebsd.org> To: Dmitry Marakasov <amdmi3@amdmi3.ru> Cc: cvs-ports@freebsd.org, Max Brazhnikov <makc@issp.ac.ru>, cvs-all@freebsd.org, ports-committers@freebsd.org Subject: Re: cvs commit: ports/Mk bsd.cmake.mk Message-ID: <874nx9gp4g.fsf@FreeBSD.org> In-Reply-To: <20111209154940.GA77124@hades.panopticon> (Dmitry Marakasov's message of "Fri, 9 Dec 2011 19:49:40 %2B0400") References: <201111101950.pAAJoQOb072790@repoman.freebsd.org> <20111209005145.GA1551@hades.panopticon> <201112091310.18922.makc@issp.ac.ru> <20111209154940.GA77124@hades.panopticon>
next in thread | previous in thread | raw e-mail | index | archive | help
Dmitry Marakasov <amdmi3@amdmi3.ru> writes: > * Max Brazhnikov (makc@issp.ac.ru) wrote: > >> > > Remove CMAKE_USE_PTHREAD. >> > > >> > > This has been in area51 since April, and discussions with makc >> > > indicate this was only needed when we supported FreeBSD < 7. >> > > >> > > Approved by: avilla (mentor), portmgr (tabthorpe) >> > > Feature safe: yes >> > > >> > > Revision Changes Path >> > > 1.13 +1 -15 ports/Mk/bsd.cmake.mk >> > >> > This has broken at least devel/bullet. This is not feature safe at all. >> >> Can you show the build log? > > http://people.freebsd.org/~amdmi3/bullet_default.log > > with LDFLAGS=-pthread it builds fine: > > http://people.freebsd.org/~amdmi3/bullet_ldflags.log > > Likely that's a correct way to fix it as bullet CMakeLists.txt > doesn't do any attempts to detect/use thread libs, however the > point is that cited commit is not safe and may touch more ports. Well, we did run test builds before committing, so it should have been a safe commit. The commit touched all ports which used the removed setting, I don't see which others it may have touched. As for the build log: what system is that? Can you post a build log with CMAKE_VERBOSE=1 set?
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?874nx9gp4g.fsf>