From owner-svn-src-all@FreeBSD.ORG Thu Feb 3 19:10:04 2011 Return-Path: Delivered-To: svn-src-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id CFDF0106564A; Thu, 3 Feb 2011 19:10:04 +0000 (UTC) (envelope-from rrs@lakerest.net) Received: from lakerest.net (unknown [IPv6:2001:240:585:2:213:d4ff:fef3:2d8d]) by mx1.freebsd.org (Postfix) with ESMTP id 7834C8FC0A; Thu, 3 Feb 2011 19:10:04 +0000 (UTC) Received: from [10.1.1.53] ([10.1.1.53]) (authenticated bits=0) by lakerest.net (8.14.4/8.14.3) with ESMTP id p13JA3RG040858 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NOT); Thu, 3 Feb 2011 14:10:03 -0500 (EST) (envelope-from rrs@lakerest.net) Mime-Version: 1.0 (Apple Message framework v1082) Content-Type: text/plain; charset=us-ascii From: Randall Stewart In-Reply-To: <201102030745.34617.jhb@freebsd.org> Date: Thu, 3 Feb 2011 14:10:03 -0500 Content-Transfer-Encoding: quoted-printable Message-Id: References: <201102031152.p13BqM8u044432@svn.freebsd.org> <201102030745.34617.jhb@freebsd.org> To: John Baldwin X-Mailer: Apple Mail (2.1082) Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r218219 - head/sys/netinet X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Feb 2011 19:10:05 -0000 John: Ahh.. thanks for the information .. I did not know that. I will change it to use it.. Before it was using the define.. which as Julian said a while ago was a bad idea. R On Feb 3, 2011, at 7:45 AM, John Baldwin wrote: > On Thursday, February 03, 2011 6:52:22 am Randall Stewart wrote: >> Author: rrs >> Date: Thu Feb 3 11:52:22 2011 >> New Revision: 218219 >> URL: http://svn.freebsd.org/changeset/base/218219 >>=20 >> Log: >> Fix the per CPU stats so that: >> 1) They don't use the giant "MAX_CPU" define and instead >> are allocated dynamically based on mp_ncpus >=20 > You probably want to use mp_maxid instead. CPU IDs are not guaranteed = to be=20 > contiguous (though they currently are). Instead, the only guarantee = are that=20 > there are mp_ncpus CPUs numbered 0 ... mp_maxid. There may be gaps in = that=20 > range (and there have been in the past). >=20 > --=20 > John Baldwin >=20 ------------------------------ Randall Stewart 803-317-4952 (cell)