From owner-svn-ports-all@FreeBSD.ORG Thu Jan 3 23:50:15 2013 Return-Path: Delivered-To: svn-ports-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id E9FC750E; Thu, 3 Jan 2013 23:50:15 +0000 (UTC) (envelope-from gjb@FreeBSD.org) Received: from onyx.glenbarber.us (onyx.glenbarber.us [IPv6:2607:fc50:1000:c200::face]) by mx1.freebsd.org (Postfix) with ESMTP id A06E2E7F; Thu, 3 Jan 2013 23:50:15 +0000 (UTC) Received: from glenbarber.us (kaos.glenbarber.us [71.224.221.174]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: gjb) by onyx.glenbarber.us (Postfix) with ESMTPSA id 27D2B23F763; Thu, 3 Jan 2013 18:50:13 -0500 (EST) DKIM-Filter: OpenDKIM Filter v2.7.1 onyx.glenbarber.us 27D2B23F763 Authentication-Results: onyx.glenbarber.us; dkim=none reason="no signature"; dkim-adsp=none (insecure policy) Date: Thu, 3 Jan 2013 18:50:10 -0500 From: Glen Barber To: Hiroki Sato Subject: Re: svn commit: r309908 - head/textproc/docproj Message-ID: <20130103235010.GA16713@glenbarber.us> References: <201301032304.r03N40Mp002548@svn.freebsd.org> <20130104.084154.34484659539126409.hrs@allbsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Q68bSM7Ycu6FN28Q" Content-Disposition: inline In-Reply-To: <20130104.084154.34484659539126409.hrs@allbsd.org> X-Operating-System: FreeBSD 10.0-CURRENT amd64 User-Agent: Mutt/1.5.21 (2010-09-15) Cc: svn-ports-head@FreeBSD.org, svn-ports-all@FreeBSD.org, ports-committers@FreeBSD.org X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Jan 2013 23:50:16 -0000 --Q68bSM7Ycu6FN28Q Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jan 04, 2013 at 08:41:54AM +0900, Hiroki Sato wrote: > gj> Log: > gj> Unset WITH_JADETEX if not otherwise specified. > gj> > [...] >=20 > Please revert this and convert it to OPTIONS_DEFINE instead. Converting this entire port to OPTIONSng has been on my todo list for a few months now, but IMHO, this port overall is very messy. > WITH_JADETEX=3Dno by default makes explanations in files/JADETEX > useless and is counterintuitive because a docproj package for > releases has been built with WITH_JADETEX=3Dyes for a long time. Some > more clean-ups are needed for consistency, but simply setting "no" by > default is still problematic and solves nothing IMO. Is WITH_JADETEX=3Dyes for release builds set in non-public build scripts? All the release build scripts for head/, stable/9/, and stable/8/ set WITH_JADETEX=3Dno. In that case, I see no immediate chance for regression, and nonintuitive behavior within the port itself is prevented. In any case, if reverting it is still necessary, I will do so. Glen --Q68bSM7Ycu6FN28Q Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iQEcBAEBCAAGBQJQ5hkyAAoJEFJPDDeguUajhfQH/iGygdqeRsc9CimI5X20ODz3 p2kmr4/2Ax5uB8B7VfmixdsbAEEaXsYIZUXhAM4lghgcDalfyFjB0CDqlSnkSmog E+CNI0U9SV54c9Ki4Rud1s+/r2dFHAKzJBMhnRpuf1KIAP2PDSPQl/BXmjOJ/Qhe DXDSjfRaCsZhoCtD5sI9eaaMqytBX3OFr1YJ5A3ElWEIWkbb5wjBRXsqNB2cTj18 vnlpzxemeTRwyZDW5/RUihx2y3SfFVfKjlJeO88WUYV1GVnkO/86VPNjbGR7DC50 IwIJJlqyyKu5rWsMjCNnScQigvzaxmm+Ss3APZr5Mmp2Yv8UalWYmejmPRVV8kE= =/Eay -----END PGP SIGNATURE----- --Q68bSM7Ycu6FN28Q--