From owner-cvs-src@FreeBSD.ORG Mon Jan 2 09:25:10 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7D8E816A41F; Mon, 2 Jan 2006 09:25:10 +0000 (GMT) (envelope-from davidxu@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3C85343D49; Mon, 2 Jan 2006 09:25:10 +0000 (GMT) (envelope-from davidxu@freebsd.org) Received: from [127.0.0.1] (root@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id k029P7w5030903; Mon, 2 Jan 2006 09:25:08 GMT (envelope-from davidxu@freebsd.org) Message-ID: <43B8F17A.7030607@freebsd.org> Date: Mon, 02 Jan 2006 17:25:14 +0800 From: David Xu User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.7.12) Gecko/20050928 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Brian Somers References: <200601020851.k028pMLR051063@repoman.freebsd.org> In-Reply-To: <200601020851.k028pMLR051063@repoman.freebsd.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/usr.bin/su su.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Jan 2006 09:25:10 -0000 Brian Somers wrote: > brian 2006-01-02 08:51:21 UTC > > FreeBSD src repository > > Modified files: > usr.bin/su su.c > Log: > Remove broken code that mucks about with tcsetpgrp() -- even if > su isn't the foreground process. Hopefully this won't break PAM, > but I couldn't find any useful information about ache's theory > that it will. > > Specifically, this change fixes the following: > > # sh > # echo $$ > # su - root -c id & > # echo $$ > > The PID output changes as su seems to be kill -STOP'ing itself > and catching the parent shell in the process. This is especially > bad if you add a ``su - user -c command &'' to an rc script! > > Sponsored by: Sophos/Activestate > Not objected to by: des > > Revision Changes Path > 1.77 +0 -7 src/usr.bin/su/su.c > > Oh, you obviously have not checked history (discussion between bde@ and me), please try following code: %sh $ su apple# kill -STOP $$ ^C^C^C