From owner-freebsd-current@FreeBSD.ORG Sun Feb 15 06:44:33 2004 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 05D9616A4CE; Sun, 15 Feb 2004 06:44:33 -0800 (PST) Received: from transport.cksoft.de (transport.cksoft.de [62.111.66.27]) by mx1.FreeBSD.org (Postfix) with ESMTP id CCD1143D2D; Sun, 15 Feb 2004 06:44:32 -0800 (PST) (envelope-from bzeeb-lists@lists.zabbadoz.net) Received: from transport.cksoft.de (localhost [127.0.0.1]) by transport.cksoft.de (Postfix) with ESMTP id 06EA01FF922; Sun, 15 Feb 2004 15:44:31 +0100 (CET) Received: by transport.cksoft.de (Postfix, from userid 66) id 4E6DB1FF91F; Sun, 15 Feb 2004 15:44:28 +0100 (CET) Received: by mail.int.zabbadoz.net (Postfix, from userid 1060) id B8DCD153CA; Sun, 15 Feb 2004 14:44:05 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by mail.int.zabbadoz.net (Postfix) with ESMTP id B64E015384; Sun, 15 Feb 2004 14:44:06 +0000 (UTC) Date: Sun, 15 Feb 2004 14:44:06 +0000 (UTC) From: "Bjoern A. Zeeb" X-X-Sender: bz@e0-0.zab2.int.zabbadoz.net To: FreeBSD current mailing list Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Virus-Scanned: by AMaViS cksoft-s20020300-20031204bz on transport.cksoft.de cc: Hajimu UMEMOTO cc: "Bjoern A. Zeeb" Subject: TEST/REVIEW IPSEC cleanup / update X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 15 Feb 2004 14:44:33 -0000 Hi, I have extracted some patches from my patchset that clean up / update IPSEC code. I have saved them into smaller junks for easier review. Please review and take that parts you like. I am currently unsure what parts from the big FreeBSD IPSEC update have been merged back to KAME thus I am initially posting all here. Though I didn't test none of these should break FAST_IPSEC (hopefully). The patches: http://sources.zabbadoz.net/freebsd/patchset/10010-ipsec-netinet-ip-output.diff ! Description: remove IMHO unneccesarry key_spdacquire and ! add a "fast path" for error case http://sources.zabbadoz.net/freebsd/patchset/10011-ipsec-netinet6-nd6-nbr.diff ! Description: remove IPSEC specifica from file; no longer needed http://sources.zabbadoz.net/freebsd/patchset/10012-ipsec-ifdef-fastipsec.diff ! Description: IPSEC and FAST_IPSEC have the same internal API now; ! so merge these (IPSEC has an extra ipsecstat) http://sources.zabbadoz.net/freebsd/patchset/10013-ipsec-key-allocsp-tag.diff ! Description: remove unsued tag argument from functions http://sources.zabbadoz.net/freebsd/patchset/10014-ipsec-unused-code.diff ! Description: remove dead code http://sources.zabbadoz.net/freebsd/patchset/10015-ipsec-correct-panic-strings.diff ! Description: fix comments (still not using %s, __func__) http://sources.zabbadoz.net/freebsd/patchset/10016-ipsec-netkey-key-consolidate.diff ! Description: move duplicate code to function http://sources.zabbadoz.net/freebsd/patchset/10017-ipsec-netkey-key-key-spdadd-freesp.diff ! Description: key_msg2sp uses key_freesp so should we on its return value http://sources.zabbadoz.net/freebsd/patchset/10018-ipsec-comment-simplify.diff ! Description: + correct panic string (still not using %s, __func__) ! + set to NULL only if not NULL before; the if is there anyway http://sources.zabbadoz.net/freebsd/patchset/10019-ipsec-ipsec-comment.diff ! Description: correct panic string (still not using %s, __func__) -- Greetings Bjoern A. Zeeb bzeeb at Zabbadoz dot NeT 56 69 73 69 74 http://www.zabbadoz.net/