Date: Tue, 9 Aug 2016 16:45:49 -0700 From: Ngie Cooper <yaneurabeya@gmail.com> To: =?UTF-8?B?SmVhbi1Tw6liYXN0aWVuIFDDqWRyb24=?= <dumbbell@freebsd.org> Cc: "src-committers@freebsd.org" <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org> Subject: Re: svn commit: r303895 - head/sys/sys Message-ID: <CAGHfRMDJ8uoLfg%2BxD%2BU_uL2_3VkGjhZ7uPZ105wkWGX6isSGrQ@mail.gmail.com> In-Reply-To: <201608092145.u79Ljlrq018467@repo.freebsd.org> References: <201608092145.u79Ljlrq018467@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Aug 9, 2016 at 2:45 PM, Jean-S=C3=A9bastien P=C3=A9dron <dumbbell@freebsd.org> wrote: > Author: dumbbell > Date: Tue Aug 9 21:45:47 2016 > New Revision: 303895 > URL: https://svnweb.freebsd.org/changeset/base/303895 > > Log: > sys/pcpu.h: Revert change introduced in r303890 > > `device_t` is not defined outside the kernel but this header is used by > eg. libkvm or vmstat(8). Thus, r303890 broke the build. > > So let's restore `struct device` here until a longer term solution is > found. > > Reported by: Michael Butler <imb@protected-networks.net>, Jenkins > MFC after: 3 days > MFC with: r303890 This is the second time this has happened in the last few months (last time was per mmacy's request IIRC for some linuxkpi stuff). Seems like this warrants a comment at least. Thanks, -Ngie
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAGHfRMDJ8uoLfg%2BxD%2BU_uL2_3VkGjhZ7uPZ105wkWGX6isSGrQ>