From owner-freebsd-usb@FreeBSD.ORG Mon Aug 25 21:53:04 2008 Return-Path: Delivered-To: freebsd-usb@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 497BD1065671; Mon, 25 Aug 2008 21:53:04 +0000 (UTC) (envelope-from volker@vwsoft.com) Received: from frontmail.ipactive.de (frontmail.maindns.de [85.214.95.103]) by mx1.freebsd.org (Postfix) with ESMTP id BAD228FC1A; Mon, 25 Aug 2008 21:53:03 +0000 (UTC) (envelope-from volker@vwsoft.com) Received: from mail.vtec.ipme.de (Q7dfe.q.ppp-pool.de [89.53.125.254]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by frontmail.ipactive.de (Postfix) with ESMTP id 75FFA128846; Mon, 25 Aug 2008 23:52:55 +0200 (CEST) Received: from cesar.sz.vwsoft.com (cesar.sz.vwsoft.com [192.168.16.3]) by mail.vtec.ipme.de (Postfix) with ESMTP id D7BE42E90F; Mon, 25 Aug 2008 23:50:30 +0200 (CEST) Message-ID: <48B3299F.5080101@vwsoft.com> Date: Mon, 25 Aug 2008 23:52:31 +0200 From: Volker User-Agent: Thunderbird 2.0.0.16 (X11/20080727) MIME-Version: 1.0 To: Antony Mawer References: <20080819211814.6CD685B4D@mail.bitblocks.com> <20080819.160510.104119134.imp@bsdimp.com> <48AB566B.5010507@mawer.org> <20080819.180450.-867152686.imp@bsdimp.com> <48ABB1FA.5070609@mawer.org> <48AFE196.7050100@vwsoft.com> <48B0EA50.2090105@mawer.org> In-Reply-To: <48B0EA50.2090105@mawer.org> X-Enigmail-Version: 0.95.1 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit MailScanner-NULL-Check: 1220305842.00919@x/DaCVpOl1HmdZkgJgl71w X-MailScanner-ID: D7BE42E90F.DB2EA X-VWSoft-MailScanner: Found to be clean X-MailScanner-From: volker@vwsoft.com X-ipactive-MailScanner-Information: Please contact the ISP for more information X-ipactive-MailScanner: Found to be clean X-ipactive-MailScanner-From: volker@vwsoft.com Cc: freebsd-usb@freebsd.org, current@freebsd.org Subject: Re: "legacy" usb stack fixes (was: Re: HEADSUP new usb code coming in.) X-BeenThere: freebsd-usb@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: FreeBSD support for USB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Aug 2008 21:53:04 -0000 On 08/24/08 06:57, Antony Mawer wrote: > On 23/08/2008 8:08 PM, Volker wrote: >> On 12/23/-58 20:59, Antony Mawer wrote: >>> M. Warner Losh wrote: >>>> In message: <48AB566B.5010507@mawer.org> >>>> Antony Mawer writes: >>>> : Warner Losh wrote: >>>> : > From: Bakul Shah >>>> : > Subject: Re: HEADSUP new usb code coming in. : > Date: Tue, 19 Aug >>>> 2008 14:18:13 -0700 >>>> : > : >> On Tue, 19 Aug 2008 22:44:20 +0200 Hans Petter Selasky >>>> wrote: >>>> : >>> New stuff (all of which I can remember right now): >>>> : >> ... >>>> : >> >>>> : >> Accidentally unplugging a mounted USB disk (without >>>> : >> unmounting it) resulted in a hang or a crash. Is this fixed? >>>> : > : > That's fixed in -current right now with the old stack. It >>>> isn't a usb >>>> : > issue at all, but a buffer cache issue. >>>> : : Is this change that is likely to be MFC'd in time for 7.1? And/or >>>> is : there a specific patch that can manually be applied to -STABLE to >>>> fix this? >>>> >>>> I should spend the time to dig into the changes in current. There >>>> turned out to be several little changes... And I need to verify all >>>> the edge cases were covered... >>> I'd be happy to test patches if you do end up doing this.. it would be >>> really nice to have in 7.1, or at least available as a patchset if it >>> isn't suitable for MFC (eg. ABI changes)... >> >> I'm a bit behind with reading emails. Please forgive me if this has >> already been answered. >> >> Don't expect the new USB stack for 7.1-R. It's too short and the new USB >> stack will introduce an ABI breakage. For that, all drivers written for >> the old USB stack need to be rewritten and I guess, we need to take care >> about 3rd party developers and inform them in advance about that massive >> change. I would not wonder if this will never get MFC'd but I don't know >> actually. > > This wasn't about the new USB stack -- we were discussing the buffer > cache and CAM-related fixes that prevents the system from panic'ing when > a USB device is unplugged without first unmounting the filesystem. These > patches are in HEAD with the existing USB stack. :-) > > --Antony > Antony, please forgive me. While re-reading the thread partially, I've also seen your question was about the old usb stack. That does happen if $SUBJECT does not match $CONTENT (you could have changed $SUBJECT when driving the discussion into another direction). Anyway, I've already had those crashes even with the "new" usb stack (but it doesn't happen everytime - YMMV). Volker