From owner-freebsd-current@FreeBSD.ORG  Thu Jun 30 16:57:52 2005
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
X-Original-To: freebsd-current@FreeBSD.org
Delivered-To: freebsd-current@FreeBSD.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 5F83416A41C
	for <freebsd-current@FreeBSD.org>; Thu, 30 Jun 2005 16:57:52 +0000 (GMT)
	(envelope-from ssouhlal@FreeBSD.org)
Received: from efnet-math.org (efnet-math.org [69.60.109.125])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 1BCF843D1D
	for <freebsd-current@FreeBSD.org>; Thu, 30 Jun 2005 16:57:51 +0000 (GMT)
	(envelope-from ssouhlal@FreeBSD.org)
Received: from [192.168.1.12] (63-170-138-118.cst-sg.blacksburg.ntc-com.net
	[63.170.138.118]) (authenticated bits=0)
	by efnet-math.org (8.13.1/8.13.1) with ESMTP id j5UGveWU014653
	(version=TLSv1/SSLv3 cipher=RC4-SHA bits=128 verify=NO);
	Thu, 30 Jun 2005 12:57:41 -0400
In-Reply-To: <42C423A9.3010603@pop.agri.ch>
References: <7mhdg4q983.wl%kuriyama@imgsrc.co.jp>
	<C2C1A959-C36C-4A22-93E9-1744B20AC332@FreeBSD.org>
	<42C30E90.3030405@pop.agri.ch>
	<59D725CA-BB01-48D5-A2D8-B2D4A9E6B177@FreeBSD.org>
	<42C423A9.3010603@pop.agri.ch>
Mime-Version: 1.0 (Apple Message framework v730)
Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed
Message-Id: <172D31AA-2EFC-4057-AAF7-98B4DA5E4CDA@FreeBSD.org>
Content-Transfer-Encoding: 7bit
From: Suleiman Souhlal <ssouhlal@FreeBSD.org>
Date: Thu, 30 Jun 2005 12:57:43 -0400
To: Andreas Tobler <toa@pop.agri.ch>
X-Mailer: Apple Mail (2.730)
Cc: Current <freebsd-current@FreeBSD.org>
Subject: Re: Acquiring lockmgr lock "ufs" with non-sleepable locks
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 30 Jun 2005 16:57:52 -0000


On Jun 30, 2005, at 12:54 PM, Andreas Tobler wrote:

> Hello Suleiman,
>
> Suleiman Souhlal wrote:
>
>
>>>> This was introduced by my commit to take out the various  
>>>> kqueue   operations outside of ufs. It is because we are trying  
>>>> to lock  the  vnode while holding the knlist mutex. I'll work on  
>>>> a fix on   wednesday, as I'll unfortunately be a bit busy until  
>>>> then. I hope   this won't cause you any inconvenience.
>>>>
>>>>
>>>
>>> Is the below the same ?
>>>
>> Yes.
>>
>>> No, I did not try the follow-up patch yet.
>>>
>> The patch should fix it. I'll commit it as soon as I get approval.
>>
>
> It did :) Thanks. The tail -f file works now.
>
> Though, I took the latest diff from your site  
> (knlist_locking-20050629-2.diff) and had to add the thing below,  
> you forgot a NULL in knlist_init.
>
> Regards,
> Andreas
>
> (p.s: patch hand edited)
>
> Index: src/sys/cam/scsi/scsi_target.c
> ===================================================================
> --- src/sys/cam/scsi/scsi_target.c    (revision 187)
> +++ src/sys/cam/scsi/scsi_target.c    (working copy)
> @@ -196,7 +196,7 @@
>      TAILQ_INIT(&softc->work_queue);
>      TAILQ_INIT(&softc->abort_queue);
>      TAILQ_INIT(&softc->user_ccb_queue);
> -    knlist_init(&softc->read_select.si_note, &softc->mtx);
> +    knlist_init(&softc->read_select.si_note, &softc->mtx, NULL,  
> NULL, NULL);
>
>      return (0);
>  }

Oops! Thanks!

--
Suleiman Souhlal     | ssouhlal@vt.edu
The FreeBSD Project  | ssouhlal@FreeBSD.org