From owner-freebsd-current@FreeBSD.ORG Fri Sep 16 20:24:00 2005 Return-Path: X-Original-To: Freebsd-current@FreeBSD.org Delivered-To: Freebsd-current@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2889116A41F for ; Fri, 16 Sep 2005 20:24:00 +0000 (GMT) (envelope-from pbowen@fastmail.fm) Received: from out4.smtp.messagingengine.com (out4.smtp.messagingengine.com [66.111.4.28]) by mx1.FreeBSD.org (Postfix) with ESMTP id 87CD743D72 for ; Fri, 16 Sep 2005 20:23:52 +0000 (GMT) (envelope-from pbowen@fastmail.fm) Received: from frontend1.internal (mysql-sessions.internal [10.202.2.149]) by frontend1.messagingengine.com (Postfix) with ESMTP id ACA58CCFD2E for ; Fri, 16 Sep 2005 16:23:50 -0400 (EDT) Received: from frontend2.messagingengine.com ([10.202.2.151]) by frontend1.internal (MEProxy); Fri, 16 Sep 2005 16:23:50 -0400 X-Sasl-enc: fDgSpcWQRg8Tmuzr0xWu6YCb/8Ma8QfbhPUsmq4SDxa14ecK/fM 1126902228 Received: from [192.168.214.123] (unknown [12.43.65.66]) by frontend2.messagingengine.com (Postfix) with ESMTP id 36B49570360 for ; Fri, 16 Sep 2005 16:23:47 -0400 (EDT) Message-ID: <432B2985.50302@fastmail.fm> Date: Fri, 16 Sep 2005 15:22:29 -0500 From: Patrick Bowen User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.5) Gecko/20041221 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Freebsd-current@FreeBSD.org References: <1126047871.687.1.camel@localhost> <4328D0F7.2090501@fastmail.fm> <2B22BF98-3FF4-4BE5-B8FF-56BB07CDB4D9@FreeBSD.org> In-Reply-To: <2B22BF98-3FF4-4BE5-B8FF-56BB07CDB4D9@FreeBSD.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 8bit Cc: Subject: Re: ATA error on 6.0-BETA4 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Sep 2005 20:24:00 -0000 Søren Schmidt wrote: > On 15/09/2005, at 3:40, Patrick Bowen wrote: > >> I've notice the same behaviour on my Dell C600. I've attached >> verbose dmesg's for -current and 5.4. When I boot 5.4 the CD-RW is >> found and I have no problems using it for either reading or writing. >> I hope they're useful for you. > > > OK, please try the below patch and let me know if that helps any. > >> I'd like to say that I have the greatest respect for *all* of you >> that work at making FreeBSD the great OS that it is. I just wonder >> where you find the time to work on it, what with your day jobs, >> family responsibilities and all... > > > I guess we have understanding environments and need for less sleep > than usual :) > > Index: ata-lowlevel.c > =================================================================== > RCS file: /home/ncvs/src/sys/dev/ata/ata-lowlevel.c,v > retrieving revision 1.71 > diff -u -r1.71 ata-lowlevel.c > --- ata-lowlevel.c 14 Sep 2005 12:45:06 -0000 1.71 > +++ ata-lowlevel.c 15 Sep 2005 07:35:41 -0000 > @@ -278,7 +278,7 @@ > /* if read data get it */ > if (request->flags & ATA_R_READ) { > - if (ata_wait(ch, atadev, (ATA_S_READY | ATA_S_DRQ)) < > 0) { > + if (ata_wait(ch, atadev, ATA_S_DRQ) < 0) { > device_printf(request->dev, > "timeout waiting for read DRQ\n"); > request->result = EIO; > > > Søren Schmidt > sos@FreeBSD.org > > > > Søren: Outstanding! The drive is now recognized at boot, I can read and write CD's, and even listen to audio CD's. It all seems to work! Such a small change had a huge impact. If you don't mind, what exactly was the purpose for making the change (other than to make things work)? Thanks for everything, Patrick