From owner-freebsd-net Wed Dec 25 13: 0:10 2002 Delivered-To: freebsd-net@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B609537B405 for ; Wed, 25 Dec 2002 13:00:09 -0800 (PST) Received: from InterJet.dellroad.org (adsl-63-194-81-26.dsl.snfc21.pacbell.net [63.194.81.26]) by mx1.FreeBSD.org (Postfix) with ESMTP id CD96B43E4A for ; Wed, 25 Dec 2002 13:00:08 -0800 (PST) (envelope-from archie@dellroad.org) Received: from arch20m.dellroad.org (arch20m.dellroad.org [10.1.1.20]) by InterJet.dellroad.org (8.9.1a/8.9.1) with ESMTP id MAA70167; Wed, 25 Dec 2002 12:48:47 -0800 (PST) Received: from arch20m.dellroad.org (localhost [127.0.0.1]) by arch20m.dellroad.org (8.12.6/8.12.6) with ESMTP id gBPKm9fi043990; Wed, 25 Dec 2002 12:48:09 -0800 (PST) (envelope-from archie@arch20m.dellroad.org) Received: (from archie@localhost) by arch20m.dellroad.org (8.12.6/8.12.6/Submit) id gBPKm84w043989; Wed, 25 Dec 2002 12:48:08 -0800 (PST) From: Archie Cobbs Message-Id: <200212252048.gBPKm84w043989@arch20m.dellroad.org> Subject: Re: Re[2]: mpd-3.10 and MySQL In-Reply-To: <10515631078.20021224111201@front.ru> To: "Vadim A. Shklyaev" Date: Wed, 25 Dec 2002 12:48:08 -0800 (PST) Cc: freebsd-net@freebsd.org X-Mailer: ELM [version 2.4ME+ PL99b (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII Sender: owner-freebsd-net@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org Vadim A. Shklyaev wrote: > One more question, some time back a man, who had made a RADIUS > patch asked you, whether can he hook directly in AuthGetData in > auth.c, and you answered that that would be incorrect. I > wondering, why? As you can see, I have rewritten every place, > where AuthGetData is called, but IMHO it would be easier to modify > just auth.c. What is right? AuthGetData() is the "right" place to do that, except that if your operation blocks for a long time (e.g., while accessing some external resource) then mpd itself will block too (mpd is event-driven, not threaded), so any other links that might be doing negotiation, LCP echoes, etc. will be delayed. In practice this is rarely a problem unless you are doing lots of links simultaneously. -Archie __________________________________________________________________________ Archie Cobbs * Packet Design * http://www.packetdesign.com To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-net" in the body of the message