From owner-freebsd-apache@freebsd.org Mon Mar 9 13:29:21 2020 Return-Path: Delivered-To: freebsd-apache@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 5DCE1262668 for ; Mon, 9 Mar 2020 13:29:21 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 48bfFs1Qdbz4WGw for ; Mon, 9 Mar 2020 13:29:21 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 10B8E262664; Mon, 9 Mar 2020 13:29:21 +0000 (UTC) Delivered-To: apache@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 0EFCC262661 for ; Mon, 9 Mar 2020 13:29:21 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 48bfFr46WGz4WFn for ; Mon, 9 Mar 2020 13:29:20 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 3E250B638 for ; Mon, 9 Mar 2020 13:29:20 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 029DTKMa084455 for ; Mon, 9 Mar 2020 13:29:20 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 029DTKGx084454 for apache@FreeBSD.org; Mon, 9 Mar 2020 13:29:20 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" From: bugzilla-noreply@freebsd.org To: apache@FreeBSD.org Subject: maintainer-feedback requested: [Bug 244695] devel/apr1: post-patch breaks tomcat-native build with gmake Date: Mon, 09 Mar 2020 13:29:20 +0000 X-Bugzilla-Type: request X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: apache@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? Message-ID: In-Reply-To: References: X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-apache@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Support of apache-related ports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Mar 2020 13:29:21 -0000 Bugzilla Automation has asked freebsd-apache mailing list for maintainer-feedback: Bug 244695: devel/apr1: post-patch breaks tomcat-native build with gmake https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D244695 --- Description --- Tomcat committer here, just discovered this while working on upstream patch= es for tomcat-native on FreeBSD. This happens when building from tomcat-native.git as well as source tarball 1.2.23. This does not happen with www/tomcat-native (explanation follows). After performing ./buildconf and ./configure, gmake says: > osipovmi@deblndw011x:~/var/Projekte/tomcat-native/native (master %=3D) > $ LC_ALL=3DC gmake > gmake: *** No rule to make target '.MAKE', needed by 'all-recursive'. St= op. But there is no such target in tcnative. > osipovmi@deblndw011x:~/var/Projekte/tomcat-native/native (master %=3D) > $ grep -r \\.MAKE . > ./build/rules.mk:all-recursive depend-recursive: .MAKE > ./build/rules.mk:clean-recursive distclean-recursive extraclean-recursive: .MAKE ./build/rules.mk is copied during ./configure from > cp /usr/local/share/apr/build-1/apr_rules.mk /net/home/osipovmi/var/Projekte/tomcat-native/native/build/rules.mk which is > osipovmi@deblndw011x:~/var/Projekte/tomcat-native/native (master %=3D) > $ grep -r \\.MAKE /usr/local/share/apr/build-1/apr_rules.mk > all-recursive depend-recursive: .MAKE > clean-recursive distclean-recursive extraclean-recursive: .MAKE I have then compiled apr-1.7.x straight from the Subversion repo from ASF a= nd see: > osipovmi@deblndw011x:/tmp/apr-1.7.x > $ grep -r \\.MAKE build-1/ So this exists in the port only. It turns out that the port Makefile does t= his > root@deblndw011x:/usr/ports/devel/apr1 > # svn diff > Index: Makefile > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > --- Makefile (revision 528101) > +++ Makefile (working copy) > @@ -128,8 +128,6 @@ > post-patch: > @${REINPLACE_CMD} -e 's/OSVERSION/${OSVERSION}/g' \ > ${APR_WRKDIR}/configure > - @${REINPLACE_CMD} -e '/recursive:/s/$$/ .MAKE/' \ > - ${APR_WRKDIR}/build/apr_rules.mk.in coming from > root@deblndw011x:/usr/ports/devel/apr1 > # svn log -c322367 Makefile > ------------------------------------------------------------------------ > r322367 | ohauer | 2013-07-06 10:43:48 +0200 (Sat, 06 Jul 2013) | 16 lines https://lists.freebsd.org/pipermail/freebsd-apache/2013-June/003177.html reveals: * Mark recursive targets with .MAKE to fix parallel builds with bmake. Whether this is still required today and why BSD make ignores .MAKE, I don't know. gmake chokes on it with tomcat-native. The reason why www/tomcat-native never failed is that patch-Makefile.in rem= oves gmake recipes and makes it bmake compliant. If you force gmake, it will instantly fail. If this post-patch is still required, it shall be removed with pre-install,= but no later than in STAGEDIR. This will make this Makefile work with bmake AND gmake.