From owner-svn-ports-all@FreeBSD.ORG  Fri Mar  7 05:17:44 2014
Return-Path: <owner-svn-ports-all@FreeBSD.ORG>
Delivered-To: svn-ports-all@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 1033)
 id ACC8D82B; Fri,  7 Mar 2014 05:17:44 +0000 (UTC)
Date: Fri, 7 Mar 2014 05:17:44 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: "Lev A. Serebryakov" <lev@FreeBSD.org>
Subject: Re: svn commit: r345100 - in head/devel/libopencm3: . files
Message-ID: <20140307051744.GA9177@FreeBSD.org>
References: <201402191508.s1JF8uOK086607@svn.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201402191508.s1JF8uOK086607@svn.freebsd.org>
User-Agent: Mutt/1.5.22 (2013-10-16)
Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org,
 ports-committers@freebsd.org
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 07 Mar 2014 05:17:44 -0000

On Wed, Feb 19, 2014 at 03:08:56PM +0000, Lev A. Serebryakov wrote:
> New Revision: 345100
> URL: http://svnweb.freebsd.org/changeset/ports/345100
> QAT: https://qat.redports.org/buildarchive/r345100/
> 
>  @@ -1,4 +1,4 @@
>  -#!/usr/bin/env python
> -+#!/usr/bin/env python2
> ++#! /usr/bin/env /usr/local/bin/python2

Can you elaborate on this change a bit?  env(1) is mostly used in this
situation to rely on PATH value in the environment, to avoid having to
specify full path to the executable, but you do precisely this.  Is it
a typo, or you rely to some other variable passed via environment?  It
also contains a style bug (space after #!).  Original line looked good
already (/usr/local/bin is in our PATH), unless I'm missing something.

> -+#!/usr/bin/python2
> ++#! /usr/local/bin/python2

This one makes more sense (modulo the style bug), but then again: what
is wrong with canonical '#!/usr/bin/env python2' ?

./danfe