From owner-freebsd-current@FreeBSD.ORG  Sun Jan  1 18:19:20 2006
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
X-Original-To: freebsd-current@freebsd.org
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 9824716A41F;
	Sun,  1 Jan 2006 18:19:20 +0000 (GMT)
	(envelope-from dunstan@freebsd.czest.pl)
Received: from freebsd.czest.pl (freebsd.czest.pl [80.48.250.4])
	by mx1.FreeBSD.org (Postfix) with ESMTP id ADABE43D58;
	Sun,  1 Jan 2006 18:19:19 +0000 (GMT)
	(envelope-from dunstan@freebsd.czest.pl)
Received: from freebsd.czest.pl (freebsd.czest.pl [80.48.250.4])
	by freebsd.czest.pl (8.12.10/8.12.9) with ESMTP id k01IMSPx017972;
	Sun, 1 Jan 2006 18:22:28 GMT (envelope-from dunstan@freebsd.czest.pl)
Received: (from dunstan@localhost)
	by freebsd.czest.pl (8.13.4/8.12.9/Submit) id k01IMSL5017971;
	Sun, 1 Jan 2006 18:22:28 GMT (envelope-from dunstan)
Date: Sun, 1 Jan 2006 18:22:27 +0000
From: "Wojciech A. Koszek" <dunstan@freebsd.czest.pl>
To: Richard Todd <rmtodd@ichotolot.servalan.com>
Message-ID: <20060101182227.GB17837@FreeBSD.czest.pl>
References: <20051221031526.31ABC290@mx2.synetsystems.com>
	<200512211111.44268.jhb@freebsd.org>
	<20051227173434.GA53513@FreeBSD.czest.pl>
	<x7hd8osrwc.fsf@ichotolot.servalan.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-8859-2
Content-Disposition: inline
In-Reply-To: <x7hd8osrwc.fsf@ichotolot.servalan.com>
User-Agent: Mutt/1.4.2.1i
Cc: freebsd-current@freebsd.org, rwatson@freebsd.org
Subject: Re: Bug in latest rev kern_acct.c: panic: Trying sleep,
	but thread marked as sleeping prohibited
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 01 Jan 2006 18:19:20 -0000

On Sat, Dec 31, 2005 at 06:39:31PM -0600, Richard Todd wrote:
> "Wojciech A. Koszek" <dunstan@freebsd.czest.pl> writes:
> 
> > On Wed, Dec 21, 2005 at 11:11:43AM -0500, John Baldwin wrote:
> >> acctwatch() probably isn't a good thing to do from a callout since it wants to 
> >> do VOPs and such.  Probably the easiest fix is to stick acctwatch() in its 
> >> own kthread.
> >
> > I think I didn't break current behaviour. Patch is here:
> >
> > http://freebsd.czest.pl/dunstan/FreeBSD/kern_acct.0.patch
> >
> > Richard, could you try to repeat your problem with my patch?
> 
> Got a chance to try a new kernel today with your patch. I tried to reproduce 
> the panic by repeatedly copying a bunch of stuff onto /usr and deleting it
> in one window, and in another repeatedly doing "make configure; make clean"
> in one rather large port.  Lots of "Accounting suspended/resumed" messages
> in the logs and no panics.  So it's looking good from here. 

Thanks for testing this. I couldn't crash my box either. I belive that
KASSERT() before suspend/resume handling will always be true, just like
ACCT_ENABLED state. In the final version of the patch I'll include some
cosmetic changes suggested by Robert Watson (thanks!).

-- 
* Wojciech A. Koszek && dunstan@FreeBSD.czest.pl