From owner-freebsd-doc@FreeBSD.ORG  Mon Jan  2 10:25:40 2006
Return-Path: <owner-freebsd-doc@FreeBSD.ORG>
X-Original-To: freebsd-doc@freebsd.org
Delivered-To: freebsd-doc@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id CF3D016A41F;
	Mon,  2 Jan 2006 10:25:40 +0000 (GMT)
	(envelope-from lothrandil@n00b.apagnu.se)
Received: from pne-smtpout2-sn2.hy.skanova.net
	(pne-smtpout2-sn2.hy.skanova.net [81.228.8.164])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 5963043D5D;
	Mon,  2 Jan 2006 10:25:37 +0000 (GMT)
	(envelope-from lothrandil@n00b.apagnu.se)
Received: from [81.232.22.43] (81.232.22.43) by
	pne-smtpout2-sn2.hy.skanova.net (7.2.069.1)
	id 43B3E4A6000B64C4; Mon, 2 Jan 2006 11:25:37 +0100
Message-ID: <43B8F18E.1010608@n00b.apagnu.se>
Date: Mon, 02 Jan 2006 10:25:34 +0100
From: Niclas Zeising <lothrandil@n00b.apagnu.se>
User-Agent: Mozilla Thunderbird 1.0.7 (Windows/20050923)
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Xin LI <delphij@freebsd.org>
References: <20060102101644.GA53576@hub.freebsd.org>
In-Reply-To: <20060102101644.GA53576@hub.freebsd.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: freebsd-doc@FreeBSD.org
Subject: Re: [PATCH FOR REVIEW] doc/en_US.ISO8859-1/books SGML cleanup
X-BeenThere: freebsd-doc@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Documentation project <freebsd-doc.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-doc>,
	<mailto:freebsd-doc-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-doc>
List-Post: <mailto:freebsd-doc@freebsd.org>
List-Help: <mailto:freebsd-doc-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-doc>,
	<mailto:freebsd-doc-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 02 Jan 2006 10:25:40 -0000

Xin LI wrote:
> Dear folks,
> 
> Recently one of our localization team member (intron@) has pointed
> out to me that we have some unescaped >, <, and &'s found in the
> SGML source.  After some discussion we think that these changes
> should be propagated back to the English version of these files
> as well.
> 
> Does the patch located at:
> 
> 	http://people.freebsd.org/~delphij/for_review/patch-books
> 
> Look appropriate?  The primary change is to escape >, <, and &, plus
> adding some "'s for attributes.
> 
> Thanks for advance!
> 
> Cheers,

The patch looks, in my eyes, ok. I've only done a quick review of it. 
You have missed a lot of ">" though. It's in the various code listings, 
where you are accessing structure members through pointers with '->'.
Nice work otherwise!
//Niclas
--