Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 9 Feb 2023 19:45:51 +0000
From:      Brooks Davis <brooks@freebsd.org>
To:        David Chisnall <theraven@freebsd.org>
Cc:        Mateusz Guzik <mjguzik@gmail.com>, freebsd-hackers <freebsd-hackers@freebsd.org>
Subject:   Re: CFT: snmalloc as libc malloc
Message-ID:  <Y%2BVNbyqkMGKtbGVi@spindle.one-eyed-alien.net>
In-Reply-To: <E140A3A2-5C4A-4458-B365-AD693AB853E8@FreeBSD.org>
References:  <2f3dcda0-5135-290a-2dff-683b2e9fe271@FreeBSD.org> <CAGudoHFYMLk6EDrSxLiWFNBoYyTKXfHLAUhZC%2BRF4eUE-rip8Q@mail.gmail.com> <E140A3A2-5C4A-4458-B365-AD693AB853E8@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help

On Thu, Feb 09, 2023 at 07:36:48PM +0000, David Chisnall wrote:
> On 9 Feb 2023, at 19:15, Mateusz Guzik <mjguzik@gmail.com> wrote:
> > 
> > it fails to build for me:
> > 
> > /usr/src/lib/libc/stdlib/snmalloc/malloc.cc:35:10: fatal error:
> > 'override/jemalloc_compat.cc' file not found
> > #include "override/jemalloc_compat.cc"
> >         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > 1 error generated.
> > --- malloc.o ---
> > *** [malloc.o] Error code 1
> > 
> > make[4]: stopped in /usr/src/lib/libc
> > /usr/src/lib/libc/stdlib/snmalloc/memcpy.cc:25:10: fatal error:
> > 'global/memcpy.h' file not found
> > #include <global/memcpy.h>
> >         ^~~~~~~~~~~~~~~~~
> > 1 error generated.
> > --- memcpy.o ---
> > *** [memcpy.o] Error code 1
> 
> This looks as if you haven???t got the submodule?  Is there anything in contrib/snmalloc?

I'd suggest adding a Makefile check for contrib/snmalloc/LICENSE or
the like with an .error with appropriate git submodule commands.

-- Brooks



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Y%2BVNbyqkMGKtbGVi>