From owner-cvs-all Tue Jan 22 9:59:41 2002 Delivered-To: cvs-all@freebsd.org Received: from storm.FreeBSD.org.uk (storm.FreeBSD.org.uk [194.242.139.170]) by hub.freebsd.org (Postfix) with ESMTP id 0126D37B404; Tue, 22 Jan 2002 09:59:37 -0800 (PST) Received: (from uucp@localhost) by storm.FreeBSD.org.uk (8.11.6/8.11.6) with UUCP id g0MHxZJ38358; Tue, 22 Jan 2002 17:59:35 GMT (envelope-from mark@grondar.za) Received: from grondar.za (mark@localhost [127.0.0.1]) by grimreaper.grondar.org (8.11.6/8.11.6) with ESMTP id g0MHw8t60275; Tue, 22 Jan 2002 17:58:08 GMT (envelope-from mark@grondar.za) Message-Id: <200201221758.g0MHw8t60275@grimreaper.grondar.org> To: Ruslan Ermilov Cc: Dag-Erling Smorgrav , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/share/mk bsd.libnames.mk References: <20020122183407.A46781@sunbay.com> In-Reply-To: <20020122183407.A46781@sunbay.com> ; from Ruslan Ermilov "Tue, 22 Jan 2002 18:34:07 +0200." Date: Tue, 22 Jan 2002 17:58:08 +0000 From: Mark Murray Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG > It's a real pita to see this change go in after I've spent so much > time hacking on this and was told to hold off for a while by Mark > Murray. Ruslan - you have 2 separate parts to your patch. I agreed to the one half, and I've disagreed with your library change. The SSH library is general purpose enough IMO to be treated as a normal library, and any more weird hackery in the makefiles is just going to make the files messy. > Please back your changed out, look at my proposed patches, and > comment on them. My patches fix much more problems that the below > changes, in a better way, and make things actually "run", not only > "compile". Backing this out is not a good move IMO, in that I believe it to be correct or at least substantially in the correct direction. M -- o Mark Murray \_ FreeBSD Services Limited O.\_ Warning: this .sig is umop ap!sdn To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message