From owner-cvs-all@FreeBSD.ORG Tue Nov 22 14:39:29 2005 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 942D316A424; Tue, 22 Nov 2005 14:39:29 +0000 (GMT) (envelope-from ru@ip.net.ua) Received: from tigra.ip.net.ua (tigra.ip.net.ua [82.193.96.10]) by mx1.FreeBSD.org (Postfix) with ESMTP id C82AC43D5D; Tue, 22 Nov 2005 14:38:56 +0000 (GMT) (envelope-from ru@ip.net.ua) Received: from localhost (rocky.ip.net.ua [82.193.96.2]) by tigra.ip.net.ua (8.12.11/8.12.11) with ESMTP id jAMEciMI073676; Tue, 22 Nov 2005 16:38:44 +0200 (EET) (envelope-from ru@ip.net.ua) Received: from tigra.ip.net.ua ([82.193.96.10]) by localhost (rocky.ipnet [82.193.96.2]) (amavisd-new, port 10024) with LMTP id 29296-02-4; Tue, 22 Nov 2005 16:38:41 +0200 (EET) Received: from heffalump.ip.net.ua (heffalump.ip.net.ua [82.193.96.213]) by tigra.ip.net.ua (8.12.11/8.12.11) with ESMTP id jAMEbBMq073606 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 22 Nov 2005 16:37:11 +0200 (EET) (envelope-from ru@ip.net.ua) Received: (from ru@localhost) by heffalump.ip.net.ua (8.13.4/8.13.4) id jAMEbL7t066546; Tue, 22 Nov 2005 16:37:21 +0200 (EET) (envelope-from ru) Date: Tue, 22 Nov 2005 16:37:21 +0200 From: Ruslan Ermilov To: John Baldwin Message-ID: <20051122143721.GE65080@ip.net.ua> References: <200511212201.jALM1Ggp080941@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="MIdTMoZhcV1D07fI" Content-Disposition: inline In-Reply-To: <200511212201.jALM1Ggp080941@repoman.freebsd.org> User-Agent: Mutt/1.5.9i X-Virus-Scanned: by amavisd-new at ip.net.ua Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/acpica acpi_pci_link.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Nov 2005 14:39:29 -0000 --MIdTMoZhcV1D07fI Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Nov 21, 2005 at 10:01:16PM +0000, John Baldwin wrote: > jhb 2005-11-21 22:01:16 UTC >=20 > FreeBSD src repository >=20 > Modified files: > sys/dev/acpica acpi_pci_link.c=20 > Log: > Fix the code to look up the BIOS IRQ for a given link device by reading > the IRQ set by the BIOS in existing devices to actually get the correct > bus number of the child PCI bus. I was not reading the bus number from > the bridge device correctly. The __BUS_ACCESSOR() macros (from which > pcib_get_bus() is built) assume that the passed in argument is a child > device. However, at the time I'm reading the bus there is no child > device yet, so I was passing in the pcib device as the child device. > The parent of the pcib device probably returned an error in the case of > a host bridge, thus resulting in random stack garbage for the bus numbe= r. > For PCI-PCI bridges, the bus number being used was actually the subvend= or > of the PCI-PCI bridge device itself. > =20 > MFC after: 1 week > =20 > Revision Changes Path > 1.49 +15 -3 src/sys/dev/acpica/acpi_pci_link.c >=20 Looks like I no longer need these hw.pci.link.LNK[A-D].irq=3D11 in /boot/loader.conf after this change. Cheers, --=20 Ruslan Ermilov ru@FreeBSD.org FreeBSD committer --MIdTMoZhcV1D07fI Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2 (FreeBSD) iD8DBQFDgy0hqRfpzJluFF4RAlcCAJ9uDbKl9/6xqX471BVMfip5IL9KjQCdHLyR aISBx/qSS8zIm/LgDUwNEEw= =eqiM -----END PGP SIGNATURE----- --MIdTMoZhcV1D07fI--