From owner-freebsd-current@FreeBSD.ORG Mon Nov 26 19:45:29 2012 Return-Path: Delivered-To: freebsd-current@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id F1F88B04 for ; Mon, 26 Nov 2012 19:45:29 +0000 (UTC) (envelope-from glebius@FreeBSD.org) Received: from cell.glebius.int.ru (glebius.int.ru [81.19.64.117]) by mx1.freebsd.org (Postfix) with ESMTP id 6E3138FC12 for ; Mon, 26 Nov 2012 19:45:29 +0000 (UTC) Received: from cell.glebius.int.ru (localhost [127.0.0.1]) by cell.glebius.int.ru (8.14.5/8.14.5) with ESMTP id qAQJjSu9007567; Mon, 26 Nov 2012 23:45:28 +0400 (MSK) (envelope-from glebius@FreeBSD.org) Received: (from glebius@localhost) by cell.glebius.int.ru (8.14.5/8.14.5/Submit) id qAQJjRqI007566; Mon, 26 Nov 2012 23:45:27 +0400 (MSK) (envelope-from glebius@FreeBSD.org) X-Authentication-Warning: cell.glebius.int.ru: glebius set sender to glebius@FreeBSD.org using -f Date: Mon, 26 Nov 2012 23:45:27 +0400 From: Gleb Smirnoff To: Kohji Okuno Subject: Re: About 802.1Q tag Message-ID: <20121126194527.GN84121@FreeBSD.org> References: <20121126.095414.2127926346996476541.okuno.kohji@jp.panasonic.com> MIME-Version: 1.0 Content-Type: text/plain; charset=koi8-r Content-Disposition: inline In-Reply-To: <20121126.095414.2127926346996476541.okuno.kohji@jp.panasonic.com> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: freebsd-current@FreeBSD.org X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Nov 2012 19:45:30 -0000 Kohji, On Mon, Nov 26, 2012 at 09:54:14AM +0900, Kohji Okuno wrote: K> Would someone check the following code? K> K> If the hardware do not process an 802.1Q tag, the kernel repacks mbuf K> in line 578-580. But, `struct ether_header *eh' was assigned at line 484. K> K> And, in line 611-637, because of the kernel refers old eh pointer, the K> kernel will misjudges its ether packet. K> K> I think that `eh = mtod(m, struct ether_header *);' is needed after K> line 580. Committed, thanks! -- Totus tuus, Glebius.