From owner-svn-src-all@FreeBSD.ORG  Thu Jul 26 08:49:05 2012
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@FreeBSD.org
Received: from lo0.su (repoman.freebsd.org [IPv6:2001:4f8:fff6::29])
	by hub.freebsd.org (Postfix) with ESMTP id 5AA4C106566B;
	Thu, 26 Jul 2012 08:49:04 +0000 (UTC) (envelope-from ru@FreeBSD.org)
Date: Thu, 26 Jul 2012 12:49:03 +0400
From: Ruslan Ermilov <ru@FreeBSD.org>
To: "David E. O'Brien" <obrien@FreeBSD.org>,
	Simon Gerraty <sjg@juniper.net>
Message-ID: <20120726084903.GA48240@lo0.su>
References: <201207180557.q6I5vheM034018@svn.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201207180557.q6I5vheM034018@svn.freebsd.org>
Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org,
	src-committers@FreeBSD.org
Subject: Re: svn commit: r238563 - head/gnu/usr.bin/groff/tmac
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 26 Jul 2012 08:49:05 -0000

On Wed, Jul 18, 2012 at 05:57:43AM +0000, David E. O'Brien wrote:
> Author: obrien
> Date: Wed Jul 18 05:57:42 2012
> New Revision: 238563
> URL: http://svn.freebsd.org/changeset/base/238563
> 
> Log:
>   a ";" tells make we want the shell to be used
>   
>   Submitted by:	Simon Gerraty <sjg@juniper.net>
> 
> Modified:
>   head/gnu/usr.bin/groff/tmac/Makefile

I don't quite understand what this change does, could you elaborate?

Without -jN (in backwards compatibility mode), the "cd" is a no-op
(whether it's terminated by `;' or not) because make will execute a
single shell per command, with cwd set to ${.OBJDIR}.

With -jN, "cd" becomes necessary because all commands are executed as
a script by one shell (the reason it was added in the first place),
but adding `;' is a no-op because commands are on separate lines.

> Modified: head/gnu/usr.bin/groff/tmac/Makefile
> ==============================================================================
> --- head/gnu/usr.bin/groff/tmac/Makefile	Wed Jul 18 05:50:40 2012	(r238562)
> +++ head/gnu/usr.bin/groff/tmac/Makefile	Wed Jul 18 05:57:42 2012	(r238563)
> @@ -68,7 +68,7 @@ beforeinstall:
>  	cd ${.CURDIR}; \
>  	    ${INSTALL} -o ${TMACOWN} -g ${TMACGRP} -m ${TMACMODE} \
>  	    koi8-r.tmac hyphen.ru ${DESTDIR}${TMACDIR}
> -	cd ${.OBJDIR}
> +	cd ${.OBJDIR};
>  .for f in ${STRIPFILES} ${SPECIALFILES}
>  	${INSTALL} -o ${TMACOWN} -g ${TMACGRP} -m ${TMACMODE} \
>  	    $f-s ${DESTDIR}${TMACDIR}/$f
> 

-- 
Ruslan Ermilov
ru@FreeBSD.org
FreeBSD committer