Date: Mon, 08 Sep 2014 17:11:21 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 193464] New: ports-mgmt/portlint: detect rc.d scripts that don't have a PROVIDE line Message-ID: <bug-193464-13@https.bugs.freebsd.org/bugzilla/>
next in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=193464 Bug ID: 193464 Summary: ports-mgmt/portlint: detect rc.d scripts that don't have a PROVIDE line Product: Ports Tree Version: Latest Hardware: Any OS: Any Status: Needs Triage Severity: Affects Only Me Priority: --- Component: Individual Port(s) Assignee: freebsd-ports-bugs@FreeBSD.org Reporter: swhetzel@gmail.com Currently, port lint detects if the rc.d script is missing from the files directory when USE_RC_SUBR is defined. We also need to check that the rc.d script to see if it is an old or new style rc.d script. New style rc.d scripts need to have a '# PROVIDE:' line. The reason for this is that /etc/rc uses find_local_scripts_new (/etc/rc.subr) to identify the new style rc.d scripts to include in the rcorder. If a new style rc.d script doesn't have this line, then the script doesn't run on startup when the *_enable variable is defined in /etc/rc.conf. This should issue a FATAL warning if '# PROVIDE:' is missing. Old style rc.d scripts are run by localpkg which uses find_local_scripts_old (/etc/rc.subr) to locate scripts that have a .sh suffix. We should issue a WARN warning on these scripts advising the port maintainer to update to the new style rc.d script. I don't know if any ports have abused USE_RC_SUBR to install an old style rc.d script using this variable, so we'll have to check it for this also. We may also need to check the pkg-plist, PLIST_FILES for for old style rc.d scripts. -- You are receiving this mail because: You are the assignee for the bug.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-193464-13>