From owner-freebsd-usb@FreeBSD.ORG Thu Nov 22 05:09:39 2012 Return-Path: Delivered-To: freebsd-usb@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id E09AD6F for ; Thu, 22 Nov 2012 05:09:39 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-ie0-f182.google.com (mail-ie0-f182.google.com [209.85.223.182]) by mx1.freebsd.org (Postfix) with ESMTP id 9F83D8FC12 for ; Thu, 22 Nov 2012 05:09:39 +0000 (UTC) Received: by mail-ie0-f182.google.com with SMTP id s9so6237506iec.13 for ; Wed, 21 Nov 2012 21:09:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=N6twd3RATIgSKXazXtDeHwzxdKGQg0/xodeOTlpyTTs=; b=Dk8kMfuGCHeBzJsOMwZGxknCplmIfHkwPvmg9GxE4xuzppgk9mwt0G/T7etmjrlEXE UOUKobXrRqjx7ftcFuP58wpPHZnUm5jFmklr/hHZnaGSbd22MFAoD/FmiNyRkdYC2QCj MP3xvzIy9XocZjL9uYcp0EbZBu/c3yIFRx8FUU/y6SKv5BnENllLbZ2IQC2P8J7vU71P QvPmM/+fzsQNw8SpTKdFYxIMouZWZiG/ONrRMA0hloyXa4I2xhDJ0DDplbwyAqo4BYg/ iL4YgBLHzkv6xBPRzNoWdtVwJG6dZAnXU8sjUiJGR3C3MK9MPQx0ojAplaCt7yGJ0BMl qr3w== Received: by 10.50.209.65 with SMTP id mk1mr2008700igc.8.1353560979174; Wed, 21 Nov 2012 21:09:39 -0800 (PST) Received: from oddish ([66.11.160.25]) by mx.google.com with ESMTPS id x7sm1544936igk.8.2012.11.21.21.09.37 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 21 Nov 2012 21:09:38 -0800 (PST) Date: Thu, 22 Nov 2012 00:09:19 -0500 From: Mark Johnston To: Hans Petter Selasky Subject: Re: [patch] fix uplcom(4) clear stall logic for PL2303HX Message-ID: <20121122050919.GA1683@oddish> References: <20121120025722.GA3338@oddish> <201211200815.19192.hselasky@c2i.net> <20121121084302.GA4136@oddish> <201211212307.20224.hselasky@c2i.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201211212307.20224.hselasky@c2i.net> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: freebsd-usb@freebsd.org X-BeenThere: freebsd-usb@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: FreeBSD support for USB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Nov 2012 05:09:40 -0000 On Wed, Nov 21, 2012 at 11:07:20PM +0100, Hans Petter Selasky wrote: > Here you go: > > http://svnweb.freebsd.org/changeset/base/243380 > > Please test and verify. > > --HPS Yep, it's working. Thanks a lot! When I was debugging the problem I noticed the UQ_OPEN_CLEARSTALL quirk, and then later discovered that it no longer has any effect. Is there any reason for keeping it around? Or can it be removed (patch below)? Thanks, -Mark diff --git a/share/man/man4/usb_quirk.4 b/share/man/man4/usb_quirk.4 index 65deafa..f017e01 100644 --- a/share/man/man4/usb_quirk.4 +++ b/share/man/man4/usb_quirk.4 @@ -76,8 +76,6 @@ mouse sends an unknown leading byte mouse has Z-axis reversed .It UQ_NO_STRINGS string descriptors are broken -.It UQ_OPEN_CLEARSTALL -device needs clear endpoint stall .It UQ_POWER_CLAIM hub lies about power status .It UQ_SPUR_BUT_UP diff --git a/sys/dev/usb/quirk/usb_quirk.c b/sys/dev/usb/quirk/usb_quirk.c index fe15a0a..8f35584 100644 --- a/sys/dev/usb/quirk/usb_quirk.c +++ b/sys/dev/usb/quirk/usb_quirk.c @@ -508,7 +508,6 @@ static const char *usb_quirk_str[USB_QUIRK_MAX] = { [UQ_MS_LEADING_BYTE] = "UQ_MS_LEADING_BYTE", [UQ_MS_REVZ] = "UQ_MS_REVZ", [UQ_NO_STRINGS] = "UQ_NO_STRINGS", - [UQ_OPEN_CLEARSTALL] = "UQ_OPEN_CLEARSTALL", [UQ_POWER_CLAIM] = "UQ_POWER_CLAIM", [UQ_SPUR_BUT_UP] = "UQ_SPUR_BUT_UP", [UQ_SWAP_UNICODE] = "UQ_SWAP_UNICODE", diff --git a/sys/dev/usb/quirk/usb_quirk.h b/sys/dev/usb/quirk/usb_quirk.h index 32a60a1..15d5f15 100644 --- a/sys/dev/usb/quirk/usb_quirk.h +++ b/sys/dev/usb/quirk/usb_quirk.h @@ -54,7 +54,6 @@ enum { UQ_MS_LEADING_BYTE, /* mouse sends an unknown leading byte */ UQ_MS_REVZ, /* mouse has Z-axis reversed */ UQ_NO_STRINGS, /* string descriptors are broken */ - UQ_OPEN_CLEARSTALL, /* device needs clear endpoint stall */ UQ_POWER_CLAIM, /* hub lies about power status */ UQ_SPUR_BUT_UP, /* spurious mouse button up events */ UQ_SWAP_UNICODE, /* has some Unicode strings swapped */